Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18116

Enum filtering fails if the value contains semicolon

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • SUIT
    • None

    Description

      UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

      Test case:
      1. http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch
      2. Use GAIA tap service.
      3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
      3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
      4. Table load error is displayed: Invalid statement: "ucd" IN ('pos.eq.dec

       

      FIREFLY-59 has been created.

       

      June 21, 2019

      ticket has been expanded to more filtering capabilities, (AND OR) conditions are available now.

      As reported, filtering fail when the value contains semicolon. Because we were using semicolon to separate conditions, this messes up the underlying query statement.
      Instead of just fixing the problem, I went ahead and allow the conditions delimiter to be either AND or OR. Although this added a useful requested feature, it also may require updates to our online help. Please coordinate with the appropriate people after merging.
      Sample conditions:
      > 0 and < 50 or is NULL
      < 0 or > 100
      in ('m31', 'm41') or is NULL

       
       
       

      Attachments

        Issue Links

          Activity

            From Loi: The problem is due to our use of semicolon as a separator.  The solution is to escape the semicolon in the value or replace our separator with a different character. 

            xiuqin Xiuqin Wu [X] (Inactive) added a comment - From Loi: The problem is due to our use of semicolon as a separator.  The solution is to escape the semicolon in the value or replace our separator with a different character. 

            Definitely a good improvement using 'AND' 'OR' for conditions. This was something we wanted to add for some time. I see that the tooltip has been changed to reflect this new capability. Great job! 

            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Definitely a good improvement using 'AND' 'OR' for conditions. This was something we wanted to add for some time. I see that the tooltip has been changed to reflect this new capability. Great job! 

            People

              loi Loi Ly
              tatianag Tatiana Goldina
              Emmanuel Joliet, Xiuqin Wu [X] (Inactive)
              Emmanuel Joliet, Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.