Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18116

Enum filtering fails if the value contains semicolon

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: SUIT
    • Labels:
      None

      Description

      UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

      Test case:
      1. http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch
      2. Use GAIA tap service.
      3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
      3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
      4. Table load error is displayed: Invalid statement: "ucd" IN ('pos.eq.dec

       

      FIREFLY-59 has been created.

       

      June 21, 2019

      ticket has been expanded to more filtering capabilities, (AND OR) conditions are available now.

      As reported, filtering fail when the value contains semicolon. Because we were using semicolon to separate conditions, this messes up the underlying query statement.
      Instead of just fixing the problem, I went ahead and allow the conditions delimiter to be either AND or OR. Although this added a useful requested feature, it also may require updates to our online help. Please coordinate with the appropriate people after merging.
      Sample conditions:
      > 0 and < 50 or is NULL
      < 0 or > 100
      in ('m31', 'm41') or is NULL

       
       
       

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-5812 Allow for visualization of filtering ranges on 1D and 2D plots

          • To Do

          Improvement - An improvement or enhancement to an existing feature or task. DM-6767 Add ability to reverse the current selection (filter) in a table viewer

          • To Do
          links to

          Web Link Pull Request

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tatianag Tatiana Goldina created issue -
            tatianag Tatiana Goldina made changes -
            Field Original Value New Value
            Epic Link DM-8742 [ 28579 ]
            tatianag Tatiana Goldina made changes -
            Team Science User Interface [ 10303 ]
            tatianag Tatiana Goldina made changes -
            Attachment Screen Shot 2019-02-28 at 8.53.11 AM.png [ 37102 ]
            tatianag Tatiana Goldina made changes -
            Attachment Screen Shot 2019-02-28 at 8.53.30 AM.png [ 37103 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8742 [ 28579 ] DM-8741 [ 28578 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04 [ 861 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Assignee Loi Ly [ loi ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04 [ 861 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-05 [ 874 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-05 [ 874 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-06 [ 875 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Description UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
            1. http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch
            2. Use GAIA tap service.
            3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
            3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
            4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_             		UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
             1. [http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch]
             2. Use GAIA tap service.
             3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
             3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
             4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_

             

            _FIREFLY-100 has been created._
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Description UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
             1. [http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch]
             2. Use GAIA tap service.
             3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
             3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
             4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_

             

            _FIREFLY-100 has been created._             		UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
             1. [http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch]
             2. Use GAIA tap service.
             3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
             3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
             4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_

             

            _FIREFLY-59 has been created._
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 4
            Hide
            Permalink
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            From Loi: The problem is due to our use of semicolon as a separator.  The solution is to escape the semicolon in the value or replace our separator with a different character. 

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - From Loi: The problem is due to our use of semicolon as a separator.  The solution is to escape the semicolon in the value or replace our separator with a different character. 
            loi Loi Ly made changes -
            Reviewers Emmanuel Joliet, Xiuqin Wu [ ejoliet, xiuqin ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            loi Loi Ly made changes -
            Remote Link This issue links to "Pull Request (Web Link)" [ 20855 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Description UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
             1. [http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch]
             2. Use GAIA tap service.
             3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
             3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
             4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_

             

            _FIREFLY-59 has been created._             		UCDs often have semicolon separator between words. If we are filtering UCDs by selecting the values with semicolon from the list of values ("categories"), it fails.

            Test case:
             1. [http://localhost:8080/firefly/firefly-dev.html?__action=layout.showDropDown&visible=true&view=TestTAPSearch]
             2. Use GAIA tap service.
             3. Search in ADQL tab: SELECT column_name, ucd FROM tap_schema.columns WHERE ucd like '%meta.main%' .
             3. In the result table, click column filter, click arrow next to ucd filer box, check 2 last entries ("pos.eq.ra;meta.main" and "pos.eq.dec;meta.main") from the list, and click filter link.
             4. Table load error is displayed: _Invalid statement: "ucd" IN ('pos.eq.dec_

             

            _FIREFLY-59 has been created._

             

            _June 21, 2019_

            _ticket has been expanded to more filtering capabilities, (AND OR) conditions are available now._
            |As reported, filtering fail when the value contains semicolon. Because we were using semicolon to separate conditions, this messes up the underlying query statement.
            Instead of just fixing the problem, I went ahead and allow the conditions delimiter to be either {{AND}} or {{OR}}. Although this added a useful requested feature, it also may require updates to our online help. Please coordinate with the appropriate people after merging.
            Sample conditions:
            {{> 0 and < 50 or is NULL}}
            {{< 0 or > 100}}
            {{in ('m31', 'm41') or is NULL}}|
             
             
             
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 4 8
            Hide
            Permalink
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Definitely a good improvement using 'AND' 'OR' for conditions. This was something we wanted to add for some time. I see that the tooltip has been changed to reflect this new capability. Great job! 

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Definitely a good improvement using 'AND' 'OR' for conditions. This was something we wanted to add for some time. I see that the tooltip has been changed to reflect this new capability. Great job! 
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue relates to DM-5812 [ DM-5812 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue relates to DM-6767 [ DM-6767 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              loi Loi Ly
              Reporter:
              tatianag Tatiana Goldina
              Reviewers:
              Emmanuel Joliet, Xiuqin Wu [X] (Inactive)
              Watchers:
              Emmanuel Joliet, Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.