Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:TSSW Sprint - Mar 04 - Mar 16
-
Team:Telescope and Site
Description
We have agreed to remove the azimuthDirection field from trackTarget command of ATMCS and make the azimuth and rotator angles absolute in TPC-163. This ticket is to update the XML and the ATMCS Simulator.
The ATMCS will also have to be updated.
One question: which is indirectly related:
- Should the azimuthCalculatedAngle field of the mountEncoders event be in the range 0, 360 or -270 to 270? We should make sure that the XML has the correct information.
MTPtg and MTMount should probably get the same treatment, but on a different ticket. Whether we actually do it depends on what the MTMount vendor says (they may have already coded it this way!).
Attachments
Issue Links
Activity
ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/72
ts_ATMCSSimulator pull request: https://github.com/lsst-ts/ts_ATMCSSimulator/pull/6
I've implemented this. Please tell me when would be the best time to merge the ticket branches. The ts_ATMCSSimulator branch is needed to work with your tiagorib/ptkernel:new_xml container. However, I think the XML cannot be updated to work with that container (ATPtg isn't setting the field, but tiagorib/ptkernel:new_xml expects it to be there).
Reviewed code in GitHub.
Merged ts_xml to develop.
Merged ts_ATMCSSimulator to develop and master and released as v0.4.0.
Served new ts_ATMCSSimulator docs to http://staff.washington.edu/rowen/ts_ATMCSSimulator/index.html
I am dismayed by the extensive unnecessary differences between the ATMCS and MTMount XML. Given how expensive MTMount changes are I assume we will choose to live with most of them. But some seem unacceptable, for instance MTMount has no command to stop tracking (nor any command to stop motion).