Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18174

constructFlat fails when image is identically zero

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
    • Team:
      External

      Description

      ccd=9 is now causing problems during flat construction, as it is reporting sky levels of zero. It's possible something has changed in the raw data (maybe it's being zeroed instead of recording noise?).

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Christopher Waters, would you be willing to review this, please?

            price@MacBook:~/LSST/pipe_drivers (tickets/DM-18174=) $ git sub
            commit 85c8131904acad323f7777304c5b732c3908f51e
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Mar 6 15:34:47 2019 -0500
             
                FlatTask.scale: undo automated line breaks
                
                They were done with the wrong line width, and they break at annoying
                spots that make things harder to read.
             
             python/lsst/pipe/drivers/constructCalibs.py | 30 ++++++++++-------------------
             1 file changed, 10 insertions(+), 20 deletions(-)
             
            commit 68da4f9fdbf6e8eea5be076dfecc0d76141eb11e (HEAD -> tickets/DM-18174, origin/tickets/DM-18174)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Mar 6 16:11:29 2019 -0500
             
                FlatTask: catch bad CCDs when scaling
                
                HSC's ccd=9 is now being set to zero, which causes FlatTask.scale to
                fail because it ends up with a row full of NANs. Catch that case, and
                set the bad CCD to have the mean scale.
             
             python/lsst/pipe/drivers/constructCalibs.py | 6 +++++-
             1 file changed, 5 insertions(+), 1 deletion(-)
             
             
             
            price@MacBook:~/LSST/obs_subaru (tickets/DM-18174=) $ git sub
            commit 6aa142beaf14222f27b82c88002095cd97824701
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Mar 7 15:28:36 2019 -0500
             
                config: remove sky2.py
                
                This was left over after testing and snuck in somehow.
             
             config/hsc/sky2.py | 9 ---------
             1 file changed, 9 deletions(-)
             
            commit d318710baac2c940864880cad1923656b6bca084
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Mar 7 15:29:56 2019 -0500
             
                config: remove references to SubaruIsrTask
                
                It's gone (DM-15862).
             
             config/hsc/bias.py                 | 2 --
             config/hsc/dark.py                 | 2 --
             config/hsc/flat.py                 | 2 --
             config/hsc/fringe.py               | 2 --
             config/hsc/sky.py                  | 2 --
             config/makeBrighterFatterKernel.py | 2 --
             6 files changed, 12 deletions(-)
             
            commit a631180b37c42de53e1c06e58e590bd85bc9a0dc (HEAD -> tickets/DM-18174, origin/tickets/DM-18174)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Mar 7 15:40:28 2019 -0500
             
                hsc: fix move of VignetteConfig
                
                It's now in ip_isr instead of obs_subaru.
             
             python/lsst/obs/hsc/calibs.py | 2 +-
             1 file changed, 1 insertion(+), 1 deletion(-)
            

            Show
            price Paul Price added a comment - Christopher Waters , would you be willing to review this, please? price@MacBook:~/LSST/pipe_drivers (tickets/DM-18174=) $ git sub commit 85c8131904acad323f7777304c5b732c3908f51e Author: Paul Price <price@astro.princeton.edu> Date: Wed Mar 6 15:34:47 2019 -0500   FlatTask.scale: undo automated line breaks They were done with the wrong line width, and they break at annoying spots that make things harder to read.   python/lsst/pipe/drivers/constructCalibs.py | 30 ++++++++++------------------- 1 file changed, 10 insertions(+), 20 deletions(-)   commit 68da4f9fdbf6e8eea5be076dfecc0d76141eb11e (HEAD -> tickets/DM-18174, origin/tickets/DM-18174) Author: Paul Price <price@astro.princeton.edu> Date: Wed Mar 6 16:11:29 2019 -0500   FlatTask: catch bad CCDs when scaling HSC's ccd=9 is now being set to zero, which causes FlatTask.scale to fail because it ends up with a row full of NANs. Catch that case, and set the bad CCD to have the mean scale.   python/lsst/pipe/drivers/constructCalibs.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)       price@MacBook:~/LSST/obs_subaru (tickets/DM-18174=) $ git sub commit 6aa142beaf14222f27b82c88002095cd97824701 Author: Paul Price <price@astro.princeton.edu> Date: Thu Mar 7 15:28:36 2019 -0500   config: remove sky2.py This was left over after testing and snuck in somehow.   config/hsc/sky2.py | 9 --------- 1 file changed, 9 deletions(-)   commit d318710baac2c940864880cad1923656b6bca084 Author: Paul Price <price@astro.princeton.edu> Date: Thu Mar 7 15:29:56 2019 -0500   config: remove references to SubaruIsrTask It's gone (DM-15862).   config/hsc/bias.py | 2 -- config/hsc/dark.py | 2 -- config/hsc/flat.py | 2 -- config/hsc/fringe.py | 2 -- config/hsc/sky.py | 2 -- config/makeBrighterFatterKernel.py | 2 -- 6 files changed, 12 deletions(-)   commit a631180b37c42de53e1c06e58e590bd85bc9a0dc (HEAD -> tickets/DM-18174, origin/tickets/DM-18174) Author: Paul Price <price@astro.princeton.edu> Date: Thu Mar 7 15:40:28 2019 -0500   hsc: fix move of VignetteConfig It's now in ip_isr instead of obs_subaru.   python/lsst/obs/hsc/calibs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
            Hide
            czw Christopher Waters added a comment -

            I'll take a look this evening.

            Show
            czw Christopher Waters added a comment - I'll take a look this evening.
            Hide
            price Paul Price added a comment -

            Jenkins is green.

            Show
            price Paul Price added a comment - Jenkins is green.
            Hide
            czw Christopher Waters added a comment -

            Looks good to me.

            Show
            czw Christopher Waters added a comment - Looks good to me.
            Hide
            price Paul Price added a comment -

            Thanks Chris!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Chris! Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Christopher Waters
                Watchers:
                Christopher Waters, Hisanori Furusawa, Paul Price, Sogo Mineo
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel