Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_qa
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:TSSW Sprint - Mar 18 - Mar 30, TSSW Sprint - Apr 1 - Apr 13, TSSW Sprint - May 28 - Jun 8, TSSW Sprint - Jan 06 - Jan 17, TSSW Sprint - Jan 21 - Feb 01, TSSW Sprint - Feb3 - Feb 14
-
Team:Telescope and Site
Description
Continuing the effort to implement the build and packaging process for T&S CSCs.
Attachments
Activity
This ticket was slightly repurposed to cover creating the salobj conda package job, as a follow on to DM-22792. The work is being done on a ts_salobj branch, https://github.com/lsst-ts/ts_salobj/tree/tickets/DM-18175 in the Jenkinsfile.conda file. The build is running at https://tssw-ci.lsst.org/job/SalObj%20Conda%20package/.
There is still more work to do, but this will be tracked by DM-23108 and DM-23108.
I think we have a good proof of concept so far. It would be good to put a little more time and effort to get this in a good shape. Part of the delay is my fault as I was not available to give some input to Rob during this week. Compliments to Rob for tracking me down and squeezing what little information I could give to him in the meantime.
Some comments that I have on the ticket that I would like to see implemented.
1) Remove dependency to ts_recipe. I think the build should be self-contained to the package. This can be accomplished by moving the build files from ts_recipes to ts_salobj (preferably in a directory on the package root).
2) Build should be self contained with respect to the tag.
In the Jenkinsfile the tag is fixed.
I think replacing this with
salobj_version = ${GIT_TAG_NAME}
|
should give the expected behavior.
Also, please, remove the tags you created for testing the Jenkins trigger... 
Dependency to ts_recipes is now removed. The docker image is now pulled from docker hub and the conda recipe was moved to within ts_salobj.
salobj_version is back to using GIT_TAG_NAME variable. The change to hardcoded was only done for testing.
Extraneous testing tags were deleted
I think this is good for another look. https://github.com/lsst-ts/ts_salobj/pull/80
Looks good... I requested the code to be rebased to develop before merging and that should be it.
I have not been able to work directly on this task, but I have been discussion building and packaging and more in general, configuration management with Gabriele and Tiago. This task will have to carry over to the next sprint.