Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Firefly
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:SUIT Sprint 2019-04, SUIT Sprint 2019-07
-
Team:Science User Interface
Description
Both Babel and ESlint are behind and should be upgraded.
- For ESLint there are also the rules to react functional components that can be added.
- We are currently using Babel 6.26, upgrade to the most recent 7.4.
- We are currently using ESlint 4.5, upgrade to 5.1
Babel Helpful docs:
ESLint Helpful docs:
- https://eslint.org/
- to add react functional component rules
- https://reactjs.org/docs/hooks-rules.html#eslint-plugin
- npm package: eslint-plugin-react-hooks
Driving reasons:
- We like to keep Babel up-to-date for support purposes.
- Github posted by security vulnerability alert at https://github.com/Caltech-IPAC/firefly/network/alerts.
- Babel 7 also adds better JSX support for react fragments.
A similar ticket in IPAC Firefly team has been scheduled for July sprint. https://jira.ipac.caltech.edu/browse/FIREFLY-74
https://jira.ipac.caltech.edu/browse/FIREFLY-74
PR https://github.com/Caltech-IPAC/firefly/pull/833