Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18354

afw test fails due to assertEqual on float

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      Using a bleed version of the conda environment, afw test case PhotoCalibTestCase fails with the following error:

       

      # create with non-zero fluxMag0 and err 
      photoCalib = lsst.afw.image.makePhotoCalibFromCalibZeroPoint(fluxMag0, fluxMag0Err) 
      self.assertEqual(photoCalib.getInstFluxAtZeroMagnitude(), fluxMag0) 
      > self.assertEqual(photoCalib.getCalibrationErr(), calibrationErr) 
      E AssertionError: 1617423020.8062096 != 1617423020.8062098

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18067 Add fluxMag0 PhotoCalib factory function

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17914 afw PhotoCalibTestCase failure using bleed environment

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Here's the PR: https://github.com/lsst/afw/pull/441

            Can you please check that this solves the issue in the new conda?

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29500/pipeline

            Show
            Parejkoj John Parejko added a comment - Here's the PR: https://github.com/lsst/afw/pull/441 Can you please check that this solves the issue in the new conda? Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29500/pipeline
            Hide
            Permalink
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

            I am running a build with the new environment and so far it works. 

            It should not make any difference with the actual environment, but you may merge on Monday so to be sure the weekly will not be affected by this change.

            Show
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - I am running a build with the new environment and so far it works.  It should not make any difference with the actual environment, but you may merge on Monday so to be sure the weekly will not be affected by this change.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I'm confused about your last statement. I would think that if the above Jenkins run passes, I'd be free to merge, and then this weekly would work in the future environment.

            Show
            Parejkoj John Parejko added a comment - I'm confused about your last statement. I would think that if the above Jenkins run passes, I'd be free to merge, and then this weekly would work in the future environment.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            If Jenkins passes for current env and new env has already got past afw (since this is a change to a test and not something that can affect dependencies), then I would think you can merge.

            Show
            tjenness Tim Jenness added a comment - If Jenkins passes for current env and new env has already got past afw (since this is a change to a test and not something that can affect dependencies), then I would think you can merge.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins passed cleanly.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Jenkins passed cleanly. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              gcomoretto Gabriele Comoretto [X] (Inactive)
              Reviewers:
              Gabriele Comoretto [X] (Inactive)
              Watchers:
              Gabriele Comoretto [X] (Inactive), John Parejko, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.