Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18357

Improvements on request_script

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      TSSW Sprint - Apr 15 - Apr 27
    • Team:
      Telescope and Site

      Description

      After using the new version of request_script for a couple of weeks I have gathered some new features that will be really helpful (I am also glad to hear that people liked the script and think we will be using it for a while). This task is to add some of the requests I've got to improve the script.

      Add user login/logout. To be able to coordinate multiple people interacting with the same instance of request_script, add a log in/out functionality. This is not to provide any kind of authentication but rather to inform users if there is anyone using at the time. Basically when someone enters the shell it will have something like:

      Please, log in with a user handle (use your slack username to make it easy to contact you).
      (login): tribeiro
      (cmd[tribeiro]): logout
      Please, log in with a user handle (use your slack username to make it easy to contact you).
      (login):
      

      Check usability of asynccmd. This is an asyncio capable version of cmd. It would make the script much more responsive if it can be incorporated.

      Add unit test.

      limit number of script in the past queue.

      Improve parameter parsing for the run command.

        Attachments

          Issue Links

            Activity

            Hide
            tribeiro Tiago Ribeiro added a comment -

            I think I implemented most features anticipated in the ticket. I did added some unit tests to cover the most important parts of the UI but coverage is still not super good (but better than nothing I guess).

            PR: https://github.com/lsst-ts/ts_scriptqueue/pull/26

            Show
            tribeiro Tiago Ribeiro added a comment - I think I implemented most features anticipated in the ticket. I did added some unit tests to cover the most important parts of the UI but coverage is still not super good (but better than nothing I guess). PR: https://github.com/lsst-ts/ts_scriptqueue/pull/26
            Hide
            tribeiro Tiago Ribeiro added a comment -

            To test the code, please use the lsstts/develop-env:develop container, which contains SAL 3.9.

            Show
            tribeiro Tiago Ribeiro added a comment - To test the code, please use the lsstts/develop-env:develop container, which contains SAL 3.9.
            Hide
            ecoughlin Eric Coughlin added a comment -

            I can confirm that these changes were implemented.

            Show
            ecoughlin Eric Coughlin added a comment - I can confirm that these changes were implemented.
            Hide
            tribeiro Tiago Ribeiro added a comment -

            PR closed and merged.

            Show
            tribeiro Tiago Ribeiro added a comment - PR closed and merged.

              People

              Assignee:
              tribeiro Tiago Ribeiro
              Reporter:
              tribeiro Tiago Ribeiro
              Reviewers:
              Eric Coughlin
              Watchers:
              Andy Clements, Eric Coughlin, James Buffill [X] (Inactive), Patrick Ingraham, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.