Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18367

Get butler working with Oracle

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_butler
    • Labels:
      None

      Description

      Create a new registry class for Oracle, and modify the sqlRegistry to behave differently based on the registry being an instance of that class.

        Attachments

          Activity

          Hide
          nlust Nate Lust added a comment -
          Show
          nlust Nate Lust added a comment - Pull requests: https://github.com/lsst/daf_butler/pull/138 And one small change in the activator: https://github.com/lsst/ctrl_mpexec/pull/15
          Hide
          salnikov Andy Salnikov added a comment -

          Nate Lust, I looked at the changes and I think some improvements are still possible. One thing that I feel strongly about is that CmdLineFwk (or other Butler clients) should not be responsible for calling butler.registry.shutdown() method, so I'd like that addition to be undone, and if something extra needs to be done in Butler itself then t should be added there. Some changes in daf_butler look a bit kludgy. This is probably OK for the moment but we want cleaner handling of all these workarounds that are there now.

          Show
          salnikov Andy Salnikov added a comment - Nate Lust , I looked at the changes and I think some improvements are still possible. One thing that I feel strongly about is that CmdLineFwk (or other Butler clients) should not be responsible for calling butler.registry.shutdown() method, so I'd like that addition to be undone, and if something extra needs to be done in Butler itself then t should be added there. Some changes in daf_butler look a bit kludgy. This is probably OK for the moment but we want cleaner handling of all these workarounds that are there now.
          Hide
          salnikov Andy Salnikov added a comment -

          Looks OK, please check comments on github.

          Show
          salnikov Andy Salnikov added a comment - Looks OK, please check comments on github.

            People

            • Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Nate Lust
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel