Chris Morrison added a comment - 19/Mar/19 4:47 PM I was able to address the issue simply by softening one of the config parameters. Specifically, I changed the number of reference objects at which the matcher always uses pessemistic mode from 2k to 1k. This causes the three above warnings be completely successful. I'm running the change though the validate_drp. I've confirmed that the values for cfht and decam and uneffected but need a bit of time to run over the HSC data.

Chris Morrison added a comment - 20/Mar/19 4:41 PM Found a slight bug in a test the minimum match distance that could cause it to throw more failure messages. All of the validate_drp runs have pass and given the same numbers. I'm just waiting on a complete run through of the visits mentioned in the ticket (not just the failed ccds). I'm starting a Jenkins run with ci_hsc in the mean time:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29542/pipeline

Chris Morrison added a comment - 21/Mar/19 5:33 PM Per the suggestions of Colin Slater , I reorder part of the pessimisticB algorithm (namely how the final maxMatchDistance is calculated) so that the previous failure messages are not longer observed. This reordering produces a quality WCS for once of the other two remain. Combining this with the a change in the number of references need to force consensus mode results in all of the CCDs matching properly. Below I show the results from just reordering the algorithm to show that the "failed" errors messages are now gone. visit= 1872 ccd= 11 processCcd.calibrate.astromRefObjLoader INFO: Loaded 1580 reference objects processCcd.calibrate.astrometry.matcher INFO: Purged 661 sources, leaving 113 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 43 sources processCcd.calibrate.astrometry.matcher INFO: Purged 661 sources, leaving 113 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 66 sources processCcd.calibrate.astrometry.matcher INFO: Purged 661 sources, leaving 113 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 57 sources processCcd.calibrate.astrometry INFO: Matched and fit WCS in 3 iterations; found 57 matches with scatter = 0.081 +- 0.043 arcsec   visit= 1868 ccd= 13 processCcd.calibrate.astromRefObjLoader INFO: Loaded 1840 reference objects processCcd.calibrate.astrometry.matcher INFO: Purged 595 sources, leaving 133 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 55 sources processCcd.calibrate.astrometry.matcher INFO: Purged 595 sources, leaving 133 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 57 sources processCcd.calibrate.astrometry.matcher INFO: Purged 595 sources, leaving 133 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 88 sources processCcd.calibrate.astrometry INFO: Matched and fit WCS in 3 iterations; found 88 matches with scatter = 0.029 +- 0.017 arcsec   visit= 22648 ccd= 4 processCcd.calibrate.astromRefObjLoader INFO: Loaded 1441 reference objects processCcd.calibrate.astrometry.matcher INFO: Purged 1109 sources, leaving 99 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 47 sources processCcd.calibrate.astrometry.matcher INFO: Purged 1109 sources, leaving 99 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 49 sources processCcd.calibrate.astrometry.matcher INFO: Purged 1109 sources, leaving 99 good sources processCcd.calibrate.astrometry.matcher INFO: Matched 65 sources processCcd.calibrate.astrometry INFO: Matched and fit WCS in 3 iterations; found 65 matches with scatter = 0.258 +- 0.146 arcsec

Chris Morrison added a comment - 22/Mar/19 10:42 AM I've tested the code against all 3 sets of validation data (HSC, CFHT, DECAM) and run on the full visits mentioned in the tickets. No hard (e.g. no matches found) or soft (the failures form this ticket or suspicions solution scatter) failures were found. The validate_drp numbers have slightly improved in the case of HSC-Y (the remainder are unchanged). Jenkins run with ci_hsc:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29555/pipeline

Colin Slater added a comment - 27/Mar/19 3:28 PM Comments on the PR; I'd like to have a second look after considering those.

Chris Morrison added a comment - 02/Apr/19 3:41 PM Colin Slater https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29613/pipeline check the new version on the pull request. I'll squash the commits once you approve. Jenkins for this version:

Colin Slater added a comment - 03/Apr/19 10:48 AM Final verify looks much better as its own function. Few minor comments on the PR. I would still like the repeated sigma clipping code extracted into a function.

Chris Morrison added a comment - 03/Apr/19 2:42 PM Final Jenkins after update:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29619/pipeline/