Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:TSSW Sprint - Apr 1 - Apr 13
-
Team:Telescope and Site
Description
Test ATDome CSC at the summit, for this task I will need the ATDome CSC ready for deployment. Initially is planned for the first week of April but can change depending on Russell Owen feedback.
Attachments
Activity
Tests executed and data was recorded.
As a summary, After Russell fixed the bugs the CSC works and can command the real ATDome.
It seems that the tcp socket disconnects randomly but the CSC can handle this and re-connect. It seems that is not affecting the usability of the software, the data still needs to be analyzed.
Some comments:
- Try to stop motion when changing state from EnabledState to any other state, as we will lose control of the ATDome when not in EnabledState
- It looks like the azimuth sends inPosition but when the ATDome (the hardware has some degrees of error) goes beyond the commanded position, tells that is not inPosition anymore. Need to check how much is an acceptable error to be inPosition.
- Home azimuth still need to be fixed as it's not hitting anything (this is a mechanical issue, not software)
- Add proper configuration when starting
- SettingsApplied should be published in the transition from standby to disable and not when first running
Regarding stopping the dome when in any state other than Enabled: I am not sure this is wise. I worry that we may start closing for rain, disable the CSC and the shutters stop moving. I wish we could stop azimuth motion but leave the shutters moving. I would like to have this discussed more widely before we change the software. (Of course there are times when we need to stop the shutters as well, but I think that's typically when personnel are in danger, and we use the stop buttons for that).
I plan to make ATDome a ConfigurableCsc once DM-18344 is merged (which provides that class) for proper configuration. That will add proper configuration at startup and I will fix settingsApplied at the same time.
Can you please explain more about "It looks like the azimuth sends inPosition but..."? I'm not sure if this is a CSC issue or a vendor issue or some combination of the two.
Thank you for performing those tests.
Regarding the inPoosition, this is more a guess from the report (file: move_azimuth.test2):
It send an inPosition=1 and then almost instantly an inPosition=0
azimuthCommandedState commandedState:2 |
azimuthCommandedState azimuth:70.0 |
moveAzimuth OK...
|
Wait 100 seconds... |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:357.05 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:357.05 |
Azimuth State:2 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:357.07 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:357.11 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
...
|
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:69.4 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:70.0 |
Azimuth State:1 |
azimuthInPosition :1 |
azimuthInPosition :0 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:70.55 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:71.06 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:71.5 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:71.89 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.21 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.47 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.67 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.8 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.88 |
position dropoutDoorOpeningPercentage:0.0 |
position mainDoorOpeningPercentage:20.0 |
position azimuthPosition:72.9 |
c
I have attached test results from tetsts. Tests were executed using the scripts in: https://github.com/aanania/local_tests_csc