Details
-
Type:
Story
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Notebooks
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:SUIT Sprint 2019-03, SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07, SUIT Sprint 2019-08, SUIT Sprint 2019-09
-
Team:Science User Interface
Description
For testing of the 17.0.1-rc1 release candidate that includes a patch for display_firefly, a set of candidate notebooks have been identified. This ticket is to propose adding these notebooks to SQuaRE's repository of notebooks which are automatically included in deployments of the LSST Science Platform Notebook Aspect. When evaluating a release candidate, these notebooks will be run to check that the Firefly functionality they demonstrate is working properly.
The notebooks include:
- The Firefly.ipynb notebook that SQuaRE is already curating
- intro-with-globular.ipynb which was used in workshops in summer 2018
- HSC-Footprints.ipynb from the examples subdirectory of the display_firefly repo
- A new notebook afwDisplay_Firefly_docs.ipynb which includes nearly all the functionality in the module docs at https://pipelines.lsst.io/modules/lsst.display.firefly
We will want to check that LSP users can access all the datasets that are used in these notebooks.
Attachments
Issue Links
- relates to
-
- Done
- links to
Activity
The pull request is from my fork of the notebook-demo repo.
I am not sure if the data in the HSC Footprints notebook is accessible to everyone.
David Shupe
added a comment - The pull request is from my fork of the notebook-demo repo.
I am not sure if the data in the HSC Footprints notebook is accessible to everyone. Simon Krughoff, Gregory Dubois-Felsmann — since David Shupe has left the project, and since there has been no action on this ticket for several months, I'm wondering if we can just close it. What do you think? Is there value in the outstanding pull request that you would like to spend time salvaging?
If Gregory Dubois-Felsmann would like to put these on master, I'm game to run them again.
Gregory Dubois-Felsmann I'm going to go ahead and close this. I think we have moved on from this, but please let me know if there is work here you'd like to salvage. I just want to get my review list clean at the moment.
This has languished long enough that I think just transplanting any work we want to save would be a better use of time than trying to get this merged.
This should definitely be salvaged; I'm sorry that this has languished.
It makes sense to re-test all this functionality against the current release before trying this again, so I'm OK with closing this ticket.
Part of Simon Krughoff's review, once the PR is created, should be to check that these notebooks all refer to datasets that are either already in the set that are made available in pop-up cloud deployments of the LSP, or added to that set.
If that is not realistic, e.g., because of the size of a dataset involved, please ask Gregory Dubois-Felsmann for further advice.