Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18544

Add python-level deprecation warnings for Calib interface

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      The deprecated package will probably not be available by the time I'm ready to merge DM-10156. This is unfortunate, but I don't want to delay merging that ticket, given the number of packages involved. I'm going to implement the various deprecated interfaces there, but they will only provide deprecation warnings at the C++ level, not python.

      This ticket is to add deprecation warnings to the python layer for all getCalib, setCalib, hasCalib methods in afw. Kian-Tat Lim and I may have to iterate on exactly how best to do that deprecation decoration.

        Attachments

          Issue Links

            Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Epic Link DM-10153 [ 31778 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggered by DM-10156 [ DM-10156 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggered by DM-17684 [ DM-17684 ]
            Parejkoj John Parejko made changes -
            Watchers John Parejko, John Swinbank, Kian-Tat Lim, Yusra AlSayyad [ John Parejko, John Swinbank, Kian-Tat Lim, Yusra AlSayyad ] John Parejko, John Swinbank, Kian-Tat Lim, Tim Jenness, Yusra AlSayyad [ John Parejko, John Swinbank, Kian-Tat Lim, Tim Jenness, Yusra AlSayyad ]
            Parejkoj John Parejko made changes -
            Link This issue is triggered by DM-16925 [ DM-16925 ]
            Hide
            Parejkoj John Parejko added a comment -

            Also add deprecated markings on all of the API added as part of DM-16925.

            Show
            Parejkoj John Parejko added a comment - Also add deprecated markings on all of the API added as part of DM-16925 .
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-19207 [ DM-19207 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-17566 [ DM-17566 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Parejkoj John Parejko made changes -
            Summary Add python-level deprecation warnings to old get/setCalib methods Add python-level deprecation warnings for Calib interface
            Hide
            Parejkoj John Parejko added a comment -

            Kian-Tat Lim: do you mind taking this review on, as what I think is our first actual use of the deprecated python decorator? I'm going with the @deprecate blah(): return _blah() approach because it doesn't require upgrading our conda version of deprecate, which you said could take a while.

            Show
            Parejkoj John Parejko added a comment - Kian-Tat Lim : do you mind taking this review on, as what I think is our first actual use of the deprecated python decorator? I'm going with the @deprecate blah(): return _blah() approach because it doesn't require upgrading our conda version of deprecate, which you said could take a while.
            Parejkoj John Parejko made changes -
            Reviewers Kian-Tat Lim [ ktl ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29661/pipeline
            Hide
            ktl Kian-Tat Lim added a comment -

            It's not the ideal way to do this, but it looks like you've found the best available way for now.  Good to go.

            Show
            ktl Kian-Tat Lim added a comment - It's not the ideal way to do this, but it looks like you've found the best available way for now.  Good to go.
            ktl Kian-Tat Lim made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Show
            Parejkoj John Parejko added a comment - Post rebase jenkins run (previous run ran into DM-19242 ): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29672/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the review. We only went one week without Calib deprecation warnings appearing to users!

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review. We only went one week without Calib deprecation warnings appearing to users! Merged and done.
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Kian-Tat Lim
              Watchers:
              John Parejko, John Swinbank, Kian-Tat Lim, Krzysztof Findeisen, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.