Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
Description
DM-13293 created support for new-style brighter-fatter kernels, specifically in b14fc9a134e7937ea703f4b93a9a79429136d7b7.
It was easy back then to support both the new style kernel objects, and the old, HSC-style numpy arrays, as Subaru still had its own isrTask.
However, during the great ISR merge, this was no longer the case, and only the HSC-style kernels are now supported.
The change was reverted here:
We need to be able to do both.
Attachments
Activity
Nice fix, thanks!
FWIW, I confirm that these changes work with obs_lsst.
James Chiang
added a comment - FWIW, I confirm that these changes work with obs_lsst.
The other relevant line is https://github.com/lsst/ip_isr/blob/master/python/lsst/ip/isr/isrTask.py#L882 as the new kernels are brigherFatterKernel and bfKernel refers explicitly to the HSC kernels.