Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18565

Fix artifacts at patch boundaries in DCR templates

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      AP S19-5
    • Team:
      Alert Production

      Description

      I'm seeing artifacts along patch boundaries in difference images, anywhere a source falls exactly on the boundary. My guess is this is caused by the model at the edge of the patch being cut off right at the bounding box, and then shifted for DCR. The DCR shift should be applied first to a larger region with a buffer of several pixels around the edges, and only trimmed to the bounding box later.

        Attachments

          Activity

          sullivan Ian Sullivan created issue -
          sullivan Ian Sullivan made changes -
          Field Original Value New Value
          Epic Link DM-17997 [ 240553 ]
          swinbank John Swinbank made changes -
          Sprint AP S19-5 [ 833 ]
          sullivan Ian Sullivan made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          sullivan Ian Sullivan added a comment -

          Could you please take a look at these changes in ip_diffim? It's a fairly small change, and fixes a bug in image differencing when using a DcrModel as a template.

          Show
          sullivan Ian Sullivan added a comment - Could you please take a look at these changes in ip_diffim ? It's a fairly small change, and fixes a bug in image differencing when using a DcrModel as a template.
          sullivan Ian Sullivan made changes -
          Reviewers Gabor Kovacs [ gkovacs ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          gkovacs Gabor Kovacs added a comment -

          Looks all right for me.

          Show
          gkovacs Gabor Kovacs added a comment - Looks all right for me.
          gkovacs Gabor Kovacs made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          sullivan Ian Sullivan made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            • Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Gabor Kovacs
              Watchers:
              Gabor Kovacs, Ian Sullivan, John Swinbank
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel