Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18589

Improve queue behavior when script fails to load.

    XMLWordPrintable

    Details

      Description

      The queue is not properly reporting when a script fails to load. For instance, following an import or syntax error… I think we need to monitor the result of the script execution and take appropriate measurements… Specially right after loading it…

      Ideally it would be nice if the add command is rejected if the script is not able to load at all, but I understand it is hard to identify load errors from different type of errors. So I guess, the queue must be able to check the execution returned value and would be good to get some traceback information.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment - - edited

          I will try to figure out how to output a suitable ScriptQueue script event when loading fails.

          Show
          rowen Russell Owen added a comment - - edited I will try to figure out how to output a suitable ScriptQueue script event when loading fails.
          Hide
          rowen Russell Owen added a comment -

          Changes:

          • Make sure the ScriptQueue script event is output when loading starts and if loading fails.
          • Add a test for a script that cannot be loaded.
          • Make QueueModel.stop_scripts more reliable and simplier
          • Improved the data output for the ScriptQueue script event, based on a request from INRIA: replacing the confusing "timestamp" and "duration" fields with more timestamps.
          • Used constants for most timeout values in the unit tests.

          ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/77
          ts_scriptqueue pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/21

          Show
          rowen Russell Owen added a comment - Changes: Make sure the ScriptQueue script event is output when loading starts and if loading fails. Add a test for a script that cannot be loaded. Make QueueModel.stop_scripts more reliable and simplier Improved the data output for the ScriptQueue script event, based on a request from INRIA: replacing the confusing "timestamp" and "duration" fields with more timestamps. Used constants for most timeout values in the unit tests. ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/77 ts_scriptqueue pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/21
          Hide
          ecoughlin Eric Coughlin added a comment -

          Ran tests for ts_xml changes and appeared to pass just fine.

          Code for scriptqueue looked good and appeared to do what the issue outlined above.

          Show
          ecoughlin Eric Coughlin added a comment - Ran tests for ts_xml changes and appeared to pass just fine. Code for scriptqueue looked good and appeared to do what the issue outlined above.
          Hide
          rowen Russell Owen added a comment -

          ts_scriptqueue merged to develop and master and released as v1.3.0.

          ts_xml merged to develop.

          WARNING: due to DM-18637 the timestamps in the updated ScriptQueue script event are not yet reliable.

          Show
          rowen Russell Owen added a comment - ts_scriptqueue merged to develop and master and released as v1.3.0. ts_xml merged to develop. WARNING: due to DM-18637 the timestamps in the updated ScriptQueue script event are not yet reliable.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            tribeiro Tiago Ribeiro
            Reviewers:
            Eric Coughlin
            Watchers:
            Andy Clements, Eric Coughlin, James Buffill [X] (Inactive), Patrick Ingraham, Russell Owen, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.