Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18610

Add fields, limited mutability, and trim/assembly-state tracking to cameraGeom

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      40
    • Sprint:
      DRP F19-5
    • Team:
      Data Release Production

      Description

      Add additional functionality to cameraGeom to reflect use cases identified in obs_lsst, while bringing obs_lsst usage in line with the intent of the cameraGeom design.  This includes:

      • Add additional amplifier/detector fields for flips in pre-raw to raw transmission.
      • Add accessor to get (computed) raw readout corner.
      • Rename methods that always reflect assembled state to make this explicit in the names; deprecate the old names.
      • Add new fields that track the trim/assembly state.
      • Add new accessors for bounding boxes and readout corner that utilize trim/assembly state.
      • Add setters for all fields, along with runtime freezing: only frozen Detectors can be added to an Exposure, but an unfrozen Detector can be obtained by copying a frozen Detector.

      At least some of these changes are API changes and will need an RFC.  I'd like to prototype them out on this ticket branch first.

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            Mostly ok, some comments to address.

            Show
            nlust Nate Lust added a comment - Mostly ok, some comments to address.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Review discussions for geom and afw have been resolved.

            Show
            krzys Krzysztof Findeisen added a comment - Review discussions for geom and afw have been resolved.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I see that I just got added as a reviewer, but it looks like quite a lot of reviewing has already been done. Krzysztof Findeisen could you let me know what you'd like me to do please?

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I see that I just got added as a reviewer, but it looks like quite a lot of reviewing has already been done. Krzysztof Findeisen could you let me know what you'd like me to do please?
            Hide
            krzys Krzysztof Findeisen added a comment -

            I didn't add you as a reviewer; Christopher Waters did. See the comment above.

            Show
            krzys Krzysztof Findeisen added a comment - I didn't add you as a reviewer; Christopher Waters did. See the comment above .
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Oh, in that case I've already reviewed it!

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Oh, in that case I've already reviewed it!

              People

              • Assignee:
                czw Christopher Waters
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Merlin Fisher-Levine, Nate Lust
                Watchers:
                Christopher Waters, Jim Bosch, Krzysztof Findeisen, Merlin Fisher-Levine, Nate Lust, Paul Price, Robert Lupton, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel