Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18667

Add support to display_firefly for obtaining and passing along an authorization token for Firefly

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: display_firefly, SUIT
    • Labels:
      None
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07, SUIT Sprint 2019-08
    • Team:
      Science User Interface

      Description

      Based on the API support for authentication tokens to be added to firefly_client under DM-18666, this ticket asks that display_firefly be modified to support both:

      • manually supplying an authorization token for Firefly when the display object is created, and
      • automatically picking up an appropriate token from a TBD mechanism in the Python process environment established by the Notebook Aspect (e.g., this may be from an environment variable with an agreed-upon name, or from a dot-file).

      The second subtask requires, of course, that the "TBD mechanism" has been defined. This will require work on the Notebook Aspect / Nublado as well.

      In each case, the token should then be passed down to the underlying firefly_client object.

      Care must be taken to be aware the different servers that might be used and to respect overrides that may be in place. The "second subtask", it-just-works, method is initially only required to work for whatever the active LSP-instance default Firefly server is (including any system-configured overrides to that). If the user wishes to use a different server, s/he may be required to supply an appropriate token manually.

        Attachments

          Issue Links

            Activity

            No builds found.
            gpdf Gregory Dubois-Felsmann created issue -
            gpdf Gregory Dubois-Felsmann made changes -
            Field Original Value New Value
            Link This issue is blocked by DM-18666 [ DM-18666 ]
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            Raised priority to critical to match the associated firefly_client ticket DM-18666.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - Raised priority to critical to match the associated firefly_client ticket DM-18666 .
            gpdf Gregory Dubois-Felsmann made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            gpdf Gregory Dubois-Felsmann made changes -
            Story Points 3
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8773 [ 28612 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04 [ 861 ]
            Hide
            shupe David Shupe added a comment -

            DM-18901 provides for passing the token in environment variable ACCESS_TOKEN. Passing a secret will be a later story. For now, the implementation can be to look for ACCESS_TOKEN and use it if it is provided.

            Show
            shupe David Shupe added a comment - DM-18901 provides for passing the token in environment variable ACCESS_TOKEN. Passing a secret will be a later story. For now, the implementation can be to look for ACCESS_TOKEN and use it if it is provided.
            shupe David Shupe made changes -
            Link This issue has to be done after DM-18901 [ DM-18901 ]
            shupe David Shupe made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            shupe David Shupe added a comment -

            The implementation has been tested on the lsst-lsp-int platform. The code changes are small since most of the work is done in firefly_client.

            Show
            shupe David Shupe added a comment - The implementation has been tested on the lsst-lsp-int platform. The code changes are small since most of the work is done in firefly_client .
            shupe David Shupe made changes -
            Reviewers Gregory Dubois-Felsmann [ gpdf ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04 [ 861 ] SUIT Sprint 2019-04, SUIT Sprint 2019-05 [ 861, 874 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04, SUIT Sprint 2019-05 [ 861, 874 ] SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06 [ 861, 874, 875 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06 [ 861, 874, 875 ] SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07 [ 861, 874, 875, 876 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07 [ 861, 874, 875, 876 ] SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07, SUIT Sprint 2019-08 [ 861, 874, 875, 876, 877 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Link This issue has to be done after DM-18901 [ DM-18901 ]
            Hide
            shupe David Shupe added a comment -

            Reviewed on Github PR by Tatiana Goldina

            Show
            shupe David Shupe added a comment - Reviewed on Github PR by Tatiana Goldina
            shupe David Shupe made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            shupe David Shupe made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              shupe David Shupe
              Reporter:
              gpdf Gregory Dubois-Felsmann
              Reviewers:
              Gregory Dubois-Felsmann
              Watchers:
              Adam Thornton, David Shupe, Gregory Dubois-Felsmann, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.