Fix Version/s: None
Component/s: display_firefly, SUIT
Sprint:SUIT Sprint 2019-04, SUIT Sprint 2019-05, SUIT Sprint 2019-06, SUIT Sprint 2019-07, SUIT Sprint 2019-08
Team:Science User Interface
Based on the API support for authentication tokens to be added to firefly_client under
DM-18666, this ticket asks that display_firefly be modified to support both:
- manually supplying an authorization token for Firefly when the display object is created, and
- automatically picking up an appropriate token from a TBD mechanism in the Python process environment established by the Notebook Aspect (e.g., this may be from an environment variable with an agreed-upon name, or from a dot-file).
The second subtask requires, of course, that the "TBD mechanism" has been defined. This will require work on the Notebook Aspect / Nublado as well.
In each case, the token should then be passed down to the underlying firefly_client object.
Care must be taken to be aware the different servers that might be used and to respect overrides that may be in place. The "second subtask", it-just-works, method is initially only required to work for whatever the active LSP-instance default Firefly server is (including any system-configured overrides to that). If the user wishes to use a different server, s/he may be required to supply an appropriate token manually.
- is blocked by
DM-18666 Add support for authorization headers to firefly_client
DM-18901 provides for passing the token in environment variable ACCESS_TOKEN. Passing a secret will be a later story. For now, the implementation can be to look for ACCESS_TOKEN and use it if it is provided.
The implementation has been tested on the lsst-lsp-int platform. The code changes are small since most of the work is done in firefly_client.
Raised priority to critical to match the associated firefly_client ticket