Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18683

Review Craig's PR and merge

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      Craig Lage has submitted a PR here:

      https://github.com/lsst/cp_pipe/pull/10/

      I will make any changes necessary to bring this to comply with DM standards (effectively doing a "review" but in the more efficient way where I just make the changes - quicker for both parties here). I will then check with Craig that I haven't ruined his work, and merge.

      John Swinbank has blessed this model.

        Attachments

          Issue Links

          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22405 Rewrite MeasurePhotonTransferCurveTask data types

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22659 Fix bitrot with how brighter-fatter kernels are handled, add option to use new gain values

          • Done
          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22776 Update Gen3 isrTask for BF corrections

          • Done

            Activity

            Hide
            Permalink
            jchiang James Chiang added a comment - - edited

            Merlin Fisher-Levine A few things I noticed while running `makeBrighterFatter.py` from the `tickets/DM-18683` branch. This is using `w_2019_16` and `obs_lsst` for imSim data:

            • A line like 

              envPrepend(PATH, $ {PRODUCT_DIR}/bin)

              is missing from `ups/cp_pipe.table`

            • no PTC plots were created when I ran with `--config doPlotPtcs=True level=DETECTOR`, but they were created with `level=AMP`.
            • Interpolated pixels don't seem to be  being masked. This was an issue for the DC2 flats since some of the data I used had signal levels near the nominal saturation level of 100k e-/pixel (as specified in `obs_lsst`). If I explicitly disable interpolation with `isr.doSaturationInterpolation=False`, I get reasonable results.  Looking at the `makeBrighterFatterKernel.py` code, I don't see any mask bits being enabled.  
            Show
            jchiang James Chiang added a comment - - edited Merlin Fisher-Levine A few things I noticed while running `makeBrighterFatter.py` from the `tickets/ DM-18683 ` branch. This is using `w_2019_16` and `obs_lsst` for imSim data: A line like envPrepend(PATH, $ {PRODUCT_DIR}/bin) is missing from `ups/cp_pipe.table` no PTC plots were created when I ran with `--config doPlotPtcs=True level=DETECTOR`, but they were created with `level=AMP`. Interpolated pixels don't seem to be  being masked. This was an issue for the DC2 flats since some of the data I used had signal levels near the nominal saturation level of 100k e-/pixel (as specified in `obs_lsst`). If I explicitly disable interpolation with `isr.doSaturationInterpolation=False`, I get reasonable results.  Looking at the `makeBrighterFatterKernel.py` code, I don't see any mask bits being enabled.  

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Watchers:
              Craig Lage, James Chiang, John Swinbank, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.