Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18683

Review Craig's PR and merge

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      Craig Lage has submitted a PR here:

      https://github.com/lsst/cp_pipe/pull/10/

      I will make any changes necessary to bring this to comply with DM standards (effectively doing a "review" but in the more efficient way where I just make the changes - quicker for both parties here). I will then check with Craig that I haven't ruined his work, and merge.

      John Swinbank has blessed this model.

        Attachments

          Issue Links

            Activity

            mfisherlevine Merlin Fisher-Levine created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Epic Link DM-16678 [ 235238 ]
            swinbank John Swinbank made changes -
            Story Points 2 6
            Team Data Release Production [ 10301 ]
            Hide
            jchiang James Chiang added a comment - - edited

            Merlin Fisher-Levine A few things I noticed while running `makeBrighterFatter.py` from the `tickets/DM-18683` branch. This is using `w_2019_16` and `obs_lsst` for imSim data:

            • A line like

              envPrepend(PATH, $ {PRODUCT_DIR}/bin)
              

              is missing from `ups/cp_pipe.table`

            • no PTC plots were created when I ran with `--config doPlotPtcs=True level=DETECTOR`, but they were created with `level=AMP`.
            • Interpolated pixels don't seem to be  being masked. This was an issue for the DC2 flats since some of the data I used had signal levels near the nominal saturation level of 100k e-/pixel (as specified in `obs_lsst`). If I explicitly disable interpolation with `isr.doSaturationInterpolation=False`, I get reasonable results.  Looking at the `makeBrighterFatterKernel.py` code, I don't see any mask bits being enabled.  
            Show
            jchiang James Chiang added a comment - - edited Merlin Fisher-Levine A few things I noticed while running `makeBrighterFatter.py` from the `tickets/ DM-18683 ` branch. This is using `w_2019_16` and `obs_lsst` for imSim data: A line like envPrepend(PATH, $ {PRODUCT_DIR}/bin) is missing from `ups/cp_pipe.table` no PTC plots were created when I ran with `--config doPlotPtcs=True level=DETECTOR`, but they were created with `level=AMP`. Interpolated pixels don't seem to be  being masked. This was an issue for the DC2 flats since some of the data I used had signal levels near the nominal saturation level of 100k e-/pixel (as specified in `obs_lsst`). If I explicitly disable interpolation with `isr.doSaturationInterpolation=False`, I get reasonable results.  Looking at the `makeBrighterFatterKernel.py` code, I don't see any mask bits being enabled.  
            swinbank John Swinbank made changes -
            Epic Link DM-16678 [ 235238 ] DM-20164 [ 323028 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-20164 [ 323028 ] DM-21252 [ 414682 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Story Points 6 30
            swinbank John Swinbank made changes -
            Epic Link DM-21252 [ 414682 ] DM-21282 [ 416928 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Link This issue has to be done after DM-22405 [ DM-22405 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Link This issue has to be done after DM-22659 [ DM-22659 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Link This issue has to be done before DM-22776 [ DM-22776 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Story Points 30 40

              People

              • Assignee:
                mfisherlevine Merlin Fisher-Levine
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Watchers:
                Craig Lage, James Chiang, John Swinbank, Merlin Fisher-Levine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel