Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18855

Pex exceptions TypeError should not inherit from RuntimeError

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_exceptions
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Arch 2019-04-01
    • Team:
      Architecture

      Description

      In working on DM-9873 I was getting confusing test failures because sometimes a pex_exceptions C++ TypeError was turning up in Python as a RuntimeError. It transpires that DM-9435 changed the C++ side such that TypeError inherits from LogicError but did not change the Python interface wrapper. This ticket will change the Python side to inherit from LogicError rather than RuntimeError.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9435 Document uses of pex::exceptions

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim one line fix plus a one line change to a test. I also took the opportunity to update the docstrings in the include file to refer to python3 versions of exceptions.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim one line fix plus a one line change to a test. I also took the opportunity to update the docstrings in the include file to refer to python3 versions of exceptions.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            It's not clear to me that the Python inheritance must be the same as the C++ inheritance when it comes to built-in exception types, but we should presumably be consistent when it comes to pex_exceptions types.  If Jenkins passes, this seems good to go.

            Show
            ktl Kian-Tat Lim added a comment - It's not clear to me that the Python inheritance must be the same as the C++ inheritance when it comes to built-in exception types, but we should presumably be consistent when it comes to pex_exceptions types.  If Jenkins passes, this seems good to go.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Kian-Tat Lim, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.