Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18860

Update ATDome to be configured in the standard way

    Details

      Description

      Make ATDome configurable in the standard fashion:

      • Update ATDome to inherit from salobj.ConfigurableCsc
      • Add a schema
      • Add an ATDome directory to ts_config_attcs.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I also made some improvements to ts_salobj, to make this work easier:

            • Make the BaseCsc.begin_<cmd> and BaseCsc.end_<cmd> methods asynchronous (long overdue)
            • Make ConfigurableCsc.configure method asynchronous
            • Call ConfigurableCsc.configure from ConfigurableCsc.start
            • Improve documentation for the startup sequence.

            ts_salobj pull request: https://github.com/lsst-ts/ts_salobj/pull/41
            ts_ATDome pull request: https://github.com/lsst-ts/ts_ATDome/pull/6
            ts_config_attcs pull request: https://github.com/lsst-ts/ts_config_attcs/pull/2

            Trivial changes that I think the package authors should merge when they are ready to update to ts_salobj v12:
            ts_ATDomeTrajectory pull request: https://github.com/lsst-ts/ts_ATDomeTrajectory/pull/7 (I will merge this one)
            ts_scheduler pull request: https://github.com/lsst-ts/ts_scheduler/pull/21
            ts_ATWhiteLightSource pull request: https://github.com/lsst-ts/ts_ATWhiteLightSource/pull/2
            ts_salobjATHexapod pull request: https://github.com/lsst-ts/ts_salobjATHexapod/pull/1

            Show
            rowen Russell Owen added a comment - - edited I also made some improvements to ts_salobj, to make this work easier: Make the BaseCsc.begin_<cmd> and BaseCsc.end_<cmd> methods asynchronous (long overdue) Make ConfigurableCsc.configure method asynchronous Call ConfigurableCsc.configure from ConfigurableCsc.start Improve documentation for the startup sequence. ts_salobj pull request: https://github.com/lsst-ts/ts_salobj/pull/41 ts_ATDome pull request: https://github.com/lsst-ts/ts_ATDome/pull/6 ts_config_attcs pull request: https://github.com/lsst-ts/ts_config_attcs/pull/2 Trivial changes that I think the package authors should merge when they are ready to update to ts_salobj v12: ts_ATDomeTrajectory pull request: https://github.com/lsst-ts/ts_ATDomeTrajectory/pull/7 (I will merge this one) ts_scheduler pull request: https://github.com/lsst-ts/ts_scheduler/pull/21 ts_ATWhiteLightSource pull request: https://github.com/lsst-ts/ts_ATWhiteLightSource/pull/2 ts_salobjATHexapod pull request: https://github.com/lsst-ts/ts_salobjATHexapod/pull/1
            Hide
            rowen Russell Owen added a comment -

            Please look at the changes to at_salobj, ts_ATDome and ts_config_attcs. The changes to the other packages are trivial, but I would like your opinion on how to proceed with them. I'm thinking I should notify the package owners and have them merge the changes when they are ready to update to ts_salobj 12 (which will have this ticket's changes).

            Show
            rowen Russell Owen added a comment - Please look at the changes to at_salobj, ts_ATDome and ts_config_attcs. The changes to the other packages are trivial, but I would like your opinion on how to proceed with them. I'm thinking I should notify the package owners and have them merge the changes when they are ready to update to ts_salobj 12 (which will have this ticket's changes).
            Hide
            tribeiro Tiago Ribeiro added a comment -

            I think the package owners must have received a notification of the PR. But, we may want to make sure everyone is informed about the change in the ts_salobj.

            Show
            tribeiro Tiago Ribeiro added a comment - I think the package owners must have received a notification of the PR. But, we may want to make sure everyone is informed about the change in the ts_salobj.
            Hide
            tribeiro Tiago Ribeiro added a comment -

            I reviewed the PRs on GitHub. Most of them where trivial. We'll need to coordinate the update with all the other CSC once they upgrade to the next release of salobj. Will probably require some announcements during standup.

            Show
            tribeiro Tiago Ribeiro added a comment - I reviewed the PRs on GitHub. Most of them where trivial. We'll need to coordinate the update with all the other CSC once they upgrade to the next release of salobj. Will probably require some announcements during standup.
            Hide
            rowen Russell Owen added a comment - - edited

            Merged ts_salobj to develop and master and tagged v3.12.0
            Merged ts_ATDome to develop and master and tagged v0.5.0
            Merged ts_config_attcs to develop
            Merged ts_ATDomeTrajectory to develop and master and tagged v0.7.0
            Updated served docs for ts_salobj, ts_ATDome and ts_ATDomeTrajectory at http://staff.washington.edu/rowen/

            That leaves 3 packages with trivial changes to be merged.

            Show
            rowen Russell Owen added a comment - - edited Merged ts_salobj to develop and master and tagged v3.12.0 Merged ts_ATDome to develop and master and tagged v0.5.0 Merged ts_config_attcs to develop Merged ts_ATDomeTrajectory to develop and master and tagged v0.7.0 Updated served docs for ts_salobj, ts_ATDome and ts_ATDomeTrajectory at http://staff.washington.edu/rowen/ That leaves 3 packages with trivial changes to be merged.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Tiago Ribeiro
                Watchers:
                Andres Anania [X] (Inactive), Russell Owen, Tiago Ribeiro
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: