Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18863

Investigate and fix warnings in daf_butler

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_butler
    • Labels:
      None

      Description

      Changes to daf_butler introduced some behavior that cause sqlalchemy deprecation warnings to be thrown. This ticket will find out why they are being thrown and attempt to fix our code or prevent the warnings from being thrown.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18601 Investigate newer SQLAlchemy versions

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            nlust Nate Lust added a comment -

            This behavior was introduced when daf_butler started using Sequences. The repr for Sequences in sqlalchemy is auto generated and in that process the generator function looks at a member of the Sequence class that is marked deprecated, which causing the warning to be thrown. Context managers were added to daf_butler to catches and suppress these warnings, and this behavior will be reported back up to sqlalchemy.

            Show
            nlust Nate Lust added a comment - This behavior was introduced when daf_butler started using Sequences. The repr for Sequences in sqlalchemy is auto generated and in that process the generator function looks at a member of the Sequence class that is marked deprecated, which causing the warning to be thrown. Context managers were added to daf_butler to catches and suppress these warnings, and this behavior will be reported back up to sqlalchemy.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Tim, do you have time to look at this ticket? Pull request at https://github.com/lsst/daf_butler/pull/143

            Show
            nlust Nate Lust added a comment - Tim, do you have time to look at this ticket? Pull request at https://github.com/lsst/daf_butler/pull/143
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks like a good compromise. Thanks for the very detailed explanation in the comments.

            Show
            tjenness Tim Jenness added a comment - Looks like a good compromise. Thanks for the very detailed explanation in the comments.

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Reviewers:
              Tim Jenness
              Watchers:
              Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.