Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18885

Log number of MeasuredStars in Associations

    XMLWordPrintable

    Details

      Description

      Looking at the recent log from the failed 300 visit jointcal run by Hiroyuki Ikeda, I noticed that I don't appear to ever log the total number of MeasuredStars in jointcal. This is an important number to help estimate memory pressure.

      It's probably simplest to count and log it at the end of Associations::selectFittedStars().

        Attachments

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          Paul Price: do you mind doing this small review? I didn't add a test for it, because it's numbers going into the log (and catching and testing things in the log is a bit of a pain), but if you have suggestions of how to test it, I'm all ears.

          Show
          Parejkoj John Parejko added a comment - Paul Price : do you mind doing this small review? I didn't add a test for it, because it's numbers going into the log (and catching and testing things in the log is a bit of a pain), but if you have suggestions of how to test it, I'm all ears.
          Hide
          price Paul Price added a comment - - edited

          I would write std::size_t instead of unsigned long, and ++foo instead of foo++, but those are just preferences. Code is good.

          I think a "test by demonstration" is sufficient; no need for a full-fledged unit test.

          Show
          price Paul Price added a comment - - edited I would write std::size_t instead of unsigned long , and ++foo instead of foo++ , but those are just preferences. Code is good. I think a "test by demonstration" is sufficient; no need for a full-fledged unit test.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the quick review, and the suggestions: I should definitely use size_t in jointcal always, and after some reading, I now see why you suggest the prefix ++-operator. Both changes implemented.

          Merged and done.

          Show
          Parejkoj John Parejko added a comment - Thanks for the quick review, and the suggestions: I should definitely use size_t in jointcal always, and after some reading, I now see why you suggest the prefix ++ -operator. Both changes implemented. Merged and done.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            Paul Price
            Watchers:
            Hiroyuki Ikeda, Jim Bosch, John Parejko, John Swinbank, Paul Price, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.