Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: jointcal
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:AP S19-5
-
Team:Alert Production
Description
Looking at the recent log from the failed 300 visit jointcal run by Hiroyuki Ikeda, I noticed that I don't appear to ever log the total number of MeasuredStars in jointcal. This is an important number to help estimate memory pressure.
It's probably simplest to count and log it at the end of Associations::selectFittedStars().
Attachments
Activity
I would write std::size_t instead of unsigned long, and ++foo instead of foo++, but those are just preferences. Code is good.
I think a "test by demonstration" is sufficient; no need for a full-fledged unit test.
Paul Price
added a comment - - edited I would write std::size_t instead of unsigned long , and ++foo instead of foo++ , but those are just preferences. Code is good.
I think a "test by demonstration" is sufficient; no need for a full-fledged unit test. Thanks for the quick review, and the suggestions: I should definitely use size_t in jointcal always, and after some reading, I now see why you suggest the prefix ++-operator. Both changes implemented.
Merged and done.
Paul Price: do you mind doing this small review? I didn't add a test for it, because it's numbers going into the log (and catching and testing things in the log is a bit of a pain), but if you have suggestions of how to test it, I'm all ears.