Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18916

newinstall.sh osx compiler string is incorrect after switch to mojave builds

    XMLWordPrintable

    Details

      Attachments

        Activity

        jhoblitt Joshua Hoblitt created issue -
        jhoblitt Joshua Hoblitt made changes -
        Field Original Value New Value
        Epic Link DM-18634 [ 247027 ]
        Hide
        jhoblitt Joshua Hoblitt added a comment -

        It also looks like the tests are broken on master.

        Show
        jhoblitt Joshua Hoblitt added a comment - It also looks like the tests are broken on master.
        jhoblitt Joshua Hoblitt made changes -
        Reviewers Tim Jenness [ tjenness ]
        Status To Do [ 10001 ] In Review [ 10004 ]
        Hide
        jhoblitt Joshua Hoblitt added a comment -

        Simon Krughoff Could you try an install of the latest weekly with the version of newinstall.sh from the PR? I have to walk iout the door in a few minutes.

        Show
        jhoblitt Joshua Hoblitt added a comment - Simon Krughoff Could you try an install of the latest weekly with the version of newinstall.sh from the PR? I have to walk iout the door in a few minutes.
        jhoblitt Joshua Hoblitt made changes -
        Reviewers Tim Jenness [ tjenness ] Simon Krughoff, Tim Jenness [ krughoff, tjenness ]
        Status In Review [ 10004 ] In Review [ 10004 ]
        Hide
        tjenness Tim Jenness added a comment -

        The change to clang is fine. I have no comment on all the other changes but I assume they are fine.

        Show
        tjenness Tim Jenness added a comment - The change to clang is fine. I have no comment on all the other changes but I assume they are fine.
        tjenness Tim Jenness made changes -
        Status In Review [ 10004 ] Reviewed [ 10101 ]
        Hide
        krughoff Simon Krughoff added a comment -

        I tried the newinstall.sh from this PR on my Mac running Mojave. I was able to install w_2019_14. I also successfully ran the SDSS demo.

        Show
        krughoff Simon Krughoff added a comment - I tried the newinstall.sh from this PR on my Mac running Mojave. I was able to install w_2019_14 . I also successfully ran the SDSS demo.
        krughoff Simon Krughoff made changes -
        Reviewers Simon Krughoff, Tim Jenness [ krughoff, tjenness ] Tim Jenness [ tjenness ]
        Hide
        jhoblitt Joshua Hoblitt added a comment -

        Thank you Tim Jenness / Simon Krughoff. I'm going to go ahead and merge the fix but leave this ticket open to try to resolve the strange travis failures.

        Show
        jhoblitt Joshua Hoblitt added a comment - Thank you Tim Jenness / Simon Krughoff . I'm going to go ahead and merge the fix but leave this ticket open to try to resolve the strange travis failures.
        Hide
        jhoblitt Joshua Hoblitt added a comment -

        The bash 3.x travis failure was non-reproducible, so it is down to the strange bundler failures.

        Show
        jhoblitt Joshua Hoblitt added a comment - The bash 3.x travis failure was non-reproducible, so it is down to the strange bundler failures.
        jhoblitt Joshua Hoblitt made changes -
        Story Points 0.25
        Hide
        jhoblitt Joshua Hoblitt added a comment -

        Changing to bundler 2.0.1, which only changes the version of bundler recorded as being used to product the Gemfile.lock resolve the error.

        Show
        jhoblitt Joshua Hoblitt added a comment - Changing to bundler 2.0.1 , which only changes the version of bundler recorded as being used to product the Gemfile.lock resolve the error.
        jhoblitt Joshua Hoblitt made changes -
        Resolution Done [ 10000 ]
        Status Reviewed [ 10101 ] Done [ 10002 ]

          People

          Assignee:
          jhoblitt Joshua Hoblitt
          Reporter:
          jhoblitt Joshua Hoblitt
          Reviewers:
          Tim Jenness
          Watchers:
          Gabriele Comoretto, Joshua Hoblitt, Simon Krughoff, Tim Jenness
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: