Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19075

jointcal is ignoring `writeChi2FilesOuterLoop`

    XMLWordPrintable

    Details

      Description

      When implementing DM-17956, I introduced a bug: jointcal should only set writeChi2Name in the outer minimization loop if writeChi2FilesOuterLoop is True. Otherwise, the "outer loop" chi2 CSV files are always written (which is bad, because they're big). Fortunately, it's an easy fix.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17956 Add option to output chi2 files at each outer fit iteration

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Hsin-Fang Chiang: This fixes the problem you reported. Can you please review the small code change (with a corrected test).

            Show
            Parejkoj John Parejko added a comment - Hsin-Fang Chiang : This fixes the problem you reported. Can you please review the small code change (with a corrected test).
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Show
            hchiang2 Hsin-Fang Chiang added a comment -
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, John Parejko, John Swinbank, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.