Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19207

Remove deprecated Calib interfaces after next release

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      AP F19-5 (October), AP F19-6 (November)
    • Team:
      Alert Production

      Description

      After v18 is released, we can remove the deprecated getCalib/setCalib accessors on Exposure (both in table, and image), ExposureInfo, and the deprecated Calib-style interface in PhotoCalib.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Hey John Parejko — this ticket is blocking release 19.0.0, which is now coming up. Any chance you'd be able to take a quick look at it soonish?

            Show
            swinbank John Swinbank added a comment - Hey John Parejko — this ticket is blocking release 19.0.0, which is now coming up. Any chance you'd be able to take a quick look at it soonish?
            Hide
            Parejkoj John Parejko added a comment - - edited

            I've removed everything from afw, but we'll need Jenkins to confirm that nothing else breaks:

            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30668/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited I've removed everything from afw, but we'll need Jenkins to confirm that nothing else breaks: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30668/pipeline
            Hide
            Parejkoj John Parejko added a comment - - edited

            Christopher Waters: are you able to review this almost-all-deletions ticket? There are 3 PRs, but the important work is on afw.

            Show
            Parejkoj John Parejko added a comment - - edited Christopher Waters : are you able to review this almost-all-deletions ticket? There are 3 PRs, but the important work is on afw.
            Hide
            czw Christopher Waters added a comment -

            This looks fine to me. I did a quick scan for "getCalib" on github, and there seem to be references in other repos: https://github.com/search?q=user%3Alsst+getCalib&type=Code

            Some of these are examples, but I just wanted to confirm that Jenkins builds, and that there's no reason to expect that these aren't going to cause problems in the future. I'm happy to take a second look if you do a global s/getCalib/getPhotoCalib/ on those.

            Show
            czw Christopher Waters added a comment - This looks fine to me. I did a quick scan for "getCalib" on github, and there seem to be references in other repos: https://github.com/search?q=user%3Alsst+getCalib&type=Code Some of these are examples, but I just wanted to confirm that Jenkins builds, and that there's no reason to expect that these aren't going to cause problems in the future. I'm happy to take a second look if you do a global s/getCalib/getPhotoCalib/ on those.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for scanning github: I've fixed the pipe_tasks insertFakes file. I thought I had a successful jenkins run, but now I can't find it, so lets try again:

            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30702/pipeline

            Show
            Parejkoj John Parejko added a comment - Thanks for scanning github: I've fixed the pipe_tasks insertFakes file. I thought I had a successful jenkins run, but now I can't find it, so lets try again: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30702/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Jenkins passed.

            Show
            Parejkoj John Parejko added a comment - Jenkins passed.
            Hide
            czw Christopher Waters added a comment -

            Looks good!

            Show
            czw Christopher Waters added a comment - Looks good!

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Christopher Waters
                Watchers:
                Christopher Waters, Gabriele Comoretto, John Parejko, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel