Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19252

Deprecate and stop using characterizeImage.refObjLoader

    XMLWordPrintable

    Details

      Description

      Some recent changes by Chris Morrison [X] on a ticket whose number I've forgotten reminded me that the use of a reference catalog to select stars in CharacterizeImageTask has never worked (that ticket removed a bit more of the code that pretended to the job).  But we still have a config option to provide a refObjLoader to CharacterizeImageTask, and moreover, many of our obs_ packages override that option, essentially because they want to make sure a particular reference catalog is anywhere one could be.

      We should (in order):

      • deprecate that config option (I'm not sure if we have a way to deprecate a descriptor, but we should figure one out);
      • stop overriding it in any obs packages;
      • (on another ticket) remove it.

       

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            It looks like the refObjLoader configuration for characterizeImage was removed from obs_lsst and obs_cfht by John Parejko in DM-34768. obs_subaru still has mention of config.refObjLoader though but maybe that one is fine?

            Show
            tjenness Tim Jenness added a comment - It looks like the refObjLoader configuration for characterizeImage was removed from obs_lsst and obs_cfht by John Parejko in DM-34768 . obs_subaru still has mention of config.refObjLoader though but maybe that one is fine?
            Hide
            jbosch Jim Bosch added a comment - - edited

            This should have been closed as a duplicate of DM-34768, which deprecated the config field itself and removed all other uses of it.  There is already an associated removal ticket (DM-34769) that is unblocked and will have to remove that lingering obs_subaru usage (which does nothing) in order to pass Jenkins.

            Show
            jbosch Jim Bosch added a comment - - edited This should have been closed as a duplicate of DM-34768 , which deprecated the config field itself and removed all other uses of it.  There is already an associated removal ticket ( DM-34769 ) that is unblocked and will have to remove that lingering obs_subaru usage (which does nothing) in order to pass Jenkins.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.