Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19323

Implement RFC-591: validate script configuration using jsonschema

    XMLWordPrintable

    Details

      Description

      Implement RFC-591: validate script configuration using jsonschema

      Update ts_scriptqueue and also existing scripts in ts_standardscripts and ts_externalscripts

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-591 Use schemas to define script configuration

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19880 Update scripts in ts_standardscripts for schema+dds scriptqueue

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/28
            The work is on a branch from the dds scriptqueue branch.

            If you want to see the effects look at tickets/DM-19323 of ts_standardscripts where I converted two scripts for this work (I may rename that ticket branch, but that's what it is right now).

            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/28 The work is on a branch from the dds scriptqueue branch. If you want to see the effects look at tickets/ DM-19323 of ts_standardscripts where I converted two scripts for this work (I may rename that ticket branch, but that's what it is right now).
            Hide
            Permalink
            ccontaxis Christopher Contaxis [X] (Inactive) added a comment -

            Overall everything looks good.

            General Note:

            • script_queue.py Line 315 is not necessary (data = data)
            Show
            ccontaxis Christopher Contaxis [X] (Inactive) added a comment - Overall everything looks good. General Note: script_queue.py Line 315 is not necessary (data = data)
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Good catch. That was an accidental leftover from changing id_data.data to data. I fixed it and rebased.

            I will postpone merging until I merge DM-19569 in order to not mess up the review of that ticket.

            Show
            rowen Russell Owen added a comment - Good catch. That was an accidental leftover from changing id_data.data to data . I fixed it and rebased. I will postpone merging until I merge DM-19569 in order to not mess up the review of that ticket.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Merged to develop and tagged there as v2.0b1. I will wait to release v2.0 until dds salobj can talk to SAL 3.9

            Show
            rowen Russell Owen added a comment - Merged to develop and tagged there as v2.0b1. I will wait to release v2.0 until dds salobj can talk to SAL 3.9

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Christopher Contaxis [X] (Inactive)
              Watchers:
              Christopher Contaxis [X] (Inactive), Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.