Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19366

afw unit tests do not run on some platforms

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      DM-10384 did away with lsst.geom's subpackages, replacing them with a monolithic lsst.geom package. This change broke the backward-compatibility aliases provided by lsst.afw.geom for DM-14429. Some runs of pytest or scons try to import these aliases, and crash.

      In the discussion of this issue on #dm, it was informally decided to simply remove the broken aliases instead of updating them – no code will be broken by this change, since the existing aliases are unusable anyway.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Tim Jenness, can you review this fix? Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Hi Tim Jenness , can you review this fix? Thanks!
            Hide
            krzys Krzysztof Findeisen added a comment -

            Also pinging Kian-Tat Lim for when he gets back – this change should only affect unpickling of pre-DM-14429 files; in particular, I'm deferring the question of how to deprecate the API to DM-17566. Is there anything special we should do as far as reporting/hotfixing goes?

            Show
            krzys Krzysztof Findeisen added a comment - Also pinging Kian-Tat Lim for when he gets back – this change should only affect unpickling of pre- DM-14429 files; in particular, I'm deferring the question of how to deprecate the API to DM-17566 . Is there anything special we should do as far as reporting/hotfixing goes?
            Hide
            tjenness Tim Jenness added a comment -

            Assuming Jenkins passes I'm fine with this.

            Show
            tjenness Tim Jenness added a comment - Assuming Jenkins passes I'm fine with this.
            Hide
            ktl Kian-Tat Lim added a comment -

            I don't think there's anything special needed.

            Show
            ktl Kian-Tat Lim added a comment - I don't think there's anything special needed.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Tim Jenness
                Watchers:
                Kian-Tat Lim, Krzysztof Findeisen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel