Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19374

pipe_task's optional dependency on ip_diffim isn't

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Team:
      Architecture

      Description

      pipe_tasks declares ip_diffim as an optional dependency, but it isn't because warpAndPsfMatch.py does an import from lsst.ip.diffim.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35670 Remove gen2 support from pipe_tasks

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            price Paul Price added a comment -

            In fact, there's a whole heap of setupOptional calls here, and I don't believe many of them at all. The main problem is that you need these "optional" packages if you want the tests to pass.

            Show
            price Paul Price added a comment - In fact, there's a whole heap of setupOptional calls here, and I don't believe many of them at all. The main problem is that you need these "optional" packages if you want the tests to pass.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This is still a problem. sphgeom is marked optional but is used in many places. It's not a problem for optional packages to be used in tests so long as there are import protections. We should wait for the DM-35670 cleanout before taking a new look at the table file.

            Show
            tjenness Tim Jenness added a comment - This is still a problem. sphgeom is marked optional but is used in many places. It's not a problem for optional packages to be used in tests so long as there are import protections. We should wait for the DM-35670 cleanout before taking a new look at the table file.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I will do a general clean up on this ticket, and this may include removing some daf_persistence doc strings from pipe_tasks.

            Show
            tjenness Tim Jenness added a comment - I will do a general clean up on this ticket, and this may include removing some daf_persistence doc strings from pipe_tasks.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -
            • Clean up table file (nothing is optional)
            • Import every file.
            • Remove more unused gen2 methods

            Jenkins completed. There are some remaining mentions of gen2 in code and a lot of it is ref_cat_name related.

            Show
            tjenness Tim Jenness added a comment - Clean up table file (nothing is optional) Import every file. Remove more unused gen2 methods Jenkins completed. There are some remaining mentions of gen2 in code and a lot of it is ref_cat_name related.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              price Paul Price
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.