Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19392

Interval class and geom Python enhancements: Stage 1

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • geom
    • None
    • External

    Description

      Implementation ticket for soon-to-be-created RFC; see that for description.

      This is a 20%-time/weekend project, hence the "External" team.  I've done it now because it genuinely should make important DM work (e.g. DM-18610, ad-hoc analysis) easier and more enjoyable, and as a result I don't feel at all guilty about asking for code review and RFC attention from others on it.  I just can't claim that me doing all of this work now was a net efficiency win for DM priorities, and so I've done it on my own time.

      Attachments

        Issue Links

          Activity

            jbosch Jim Bosch added a comment - PRs are up: https://github.com/lsst/geom/pull/21 https://github.com/lsst/afw/pull/459 https://github.com/lsst/sphgeom/pull/19 Code review is waiting on resolution of RFC-593 .
            jbosch Jim Bosch added a comment -

            jmeyers314, I've rebased the branches for this ticket on master (lots of commits in geom in particular had already been merged on DM-18610), and kicked off a Jenkins run.

            But I don't have time to make the additions you proposed on the sphgeom PR right now, though I agree they're a good idea.  Would you be up for just making those additions yourself, and I can review your commits?

            I've also set you as a reviewer for the geom and afw branches, which are now pretty small.

            jbosch Jim Bosch added a comment - jmeyers314 , I've rebased the branches for this ticket on master (lots of commits in  geom in particular had already been merged on DM-18610 ), and kicked off a Jenkins run. But I don't have time to make the additions you proposed on the sphgeom PR right now, though I agree they're a good idea.  Would you be up for just making those additions yourself, and I can review your commits? I've also set you as a reviewer for the geom and afw branches, which are now pretty small.

            Would you be up for just making those additions yourself, and I can review your commits?

            Yep, happy to.

             

            jmeyers314 Joshua Meyers added a comment - Would you be up for just making those additions yourself, and I can review your commits? Yep, happy to.  

            Thanks jbosch .  All PRs look good to me.  Throwing my sphgeom additions back to you.

            jmeyers314 Joshua Meyers added a comment - Thanks jbosch  .  All PRs look good to me.  Throwing my sphgeom additions back to you.
            jbosch Jim Bosch added a comment -

            Thanks; your changes look good to, and I've finally resolve the ancient comment from krzys on the geom PR.  Doing one more Jenkins run before merge, just in case.

            jbosch Jim Bosch added a comment - Thanks; your changes look good to, and I've finally resolve the ancient comment from krzys on the geom PR.  Doing one more Jenkins run before merge, just in case.

            People

              jbosch Jim Bosch
              jbosch Jim Bosch
              Joshua Meyers
              Jim Bosch, John Parejko, Joshua Meyers, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.