I am willing to review, but want to make sure I have all the tickets and branches straight in my head.
- You mention
DM-17548 above, but that must be a typo for DM-17458 (complete docstrings in ip_diffim), no problem.
- You point out that
DM-19670 (another ip_diffim docstring update ticket) has some of the items originally allocated to DM-17458, that's fine and I will trust the reviewer of that ticket to look at those changes (hi Ian Sullivan!).
- This ticket appears to have a user branch that has already been merged into master (albeit in an diffimTests, an lsst-dm repo). This does not follow standard DM workflow; the developer guide says user branches must be converted into a ticket branch first and can then go through code review and get merged into master. This is true for lsst organization repos as well as lsst-dm. Is it possible to revert this merge, and then if there is something in it you do want to land on master, I can review that too?
I will take a look at the documentation and plotting additions in the ip_diffim PR in more detail on GitHub and leave comments over there.
Is there someplace you could put an example for how to use the various plotting scripts that live in utils.py, and a list of the plots it is currently capable of making? There seem to be lots of potentially useful plotters in there with very minimal documentation. I worry about adding a many more custom ones that are used for just a couple special cases. Perhaps this warrants its own ticket, but it is not obvious at a glance how one would use the new plotKernelCoefficients function you added, much less any of the others.