Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19458

FieldValidationError usage incorrect in many tasks

    XMLWordPrintable

    Details

      Description

      While looking up how to use FieldValidationError, I discovered that several of our existing instantiations of it are incorrect and would thus raise an exception themselves! It takes (field, config, msg), and I found 4 uses that just pass msg.

      It is probably worth cleaning up the docstrings of this custom exception at the same time.

        Attachments

          Activity

          Hide
          Parejkoj John Parejko added a comment - - edited

          Tim Jenness: do you mind taking on this short review? I'm not sure what else to add to the docstring for the exception class itself.

          Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29716/pipeline

          Show
          Parejkoj John Parejko added a comment - - edited Tim Jenness : do you mind taking on this short review? I'm not sure what else to add to the docstring for the exception class itself. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29716/pipeline
          Hide
          tjenness Tim Jenness added a comment -

          I don't know anything about pex_config but this looks okay to me.

          Show
          tjenness Tim Jenness added a comment - I don't know anything about pex_config but this looks okay to me.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the quick review.

          Merged and done.

          Show
          Parejkoj John Parejko added a comment - Thanks for the quick review. Merged and done.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            Parejkoj John Parejko
            Reviewers:
            Tim Jenness
            Watchers:
            John Parejko, John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: