Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:TSSW Sprint - Apr 15 - Apr 27, TSSW Sprint - Apr 29 - May 11, TSSW Sprint - May 13 - May 25
-
Team:Telescope and Site
Description
Chiller and White Light CSCs were separated at some point in the past because they were going to be in different languages and written by different people. Now they're both python and I'm working on both. So we've decided to simplify them a single CSC rather than a pair of CSCs with a third CSC coordinating.
This task is to bring the currently-existing code for the chiller into the White Light CSC, merge their SAL topics, and get a docker environment up and running for the new unified CSC.
Attachments
Activity
also spent some time resolving an issue that was preventing the white light CSC from working with the latest salobj in the develop-env docker container.
This is another one that I finished a while ago. The chiller communication class I showed you yesterday was all already part of ATWhiteLight. Here's a link to the ATWhiteLight repo with the chiller stuff merged in: https://github.com/lsst-ts/ts_ATWhiteLightSource/tree/develop/python/lsst/ts/ATWhiteLightSource
The XML part of the merge is here: https://github.com/lsst-ts/ts_xml/pull/85
Rob has already run his tests on this branch so I assigned him the PR review.
Merge in (added) following files:
- chillerComponent.py
- chillerEncoder.py
- chillerModel.py
- chillerResponseProcessor.py
- sockscript.py
Good to go!
Done
merged code, https://github.com/lsst-ts/ts_ATWhiteLightSource/commit/863d350474420e60bbebe79374766347c2bd4bc1
merged sal commands, https://github.com/lsst-ts/ts_xml/commit/d41ec9d815a18fb97d57dcead15347218d1b1626