Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1953

Post meas_base move changes to Kron

    Details

      Description

      These are to note leftovers from DM-982. They could be done in a single issue.
      1. I commented code out referring to correctfluxes, but it will need to be restored once it is available in the new framework.

      2. Jim asked me to replace the computeSincFlux which is currently in PsfImage.cc in meas_algorithms with a similar call in meas_base/ApertureFlux.cc. I did not do this because it became rather complicated, and can just as easily be done when the meas_algorithms routine is moved or removed. Basically, the templating in ApertureFlux is on Pixel type, whereas in meas_algorithms it is on ImageT (where ImageT is not necessarily a single class hierarchy – e.g., Image and MaskedImage). So I left this for now.

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            John, can you move this issue to review complete or defer it, depending on whether you think that there is still work to be done on it? I think the only open issue has to do with aperture corrections.

            Show
            pgee Perry Gee added a comment - John, can you move this issue to review complete or defer it, depending on whether you think that there is still work to be done on it? I think the only open issue has to do with aperture corrections.
            Hide
            swinbank John Swinbank added a comment -

            Hi Perry – my comment above is still outstanding. If changes will need to be made to _photometryKron when DM-85 is done, we need a way of tracking that. It could be this issue, or it could be another issue, but it should be clear which. If those changes don't need to be made, then we can close this issue, but we need a clear statement to that effect.

            Show
            swinbank John Swinbank added a comment - Hi Perry – my comment above is still outstanding. If changes will need to be made to _photometryKron when DM-85 is done, we need a way of tracking that. It could be this issue, or it could be another issue, but it should be clear which. If those changes don't need to be made, then we can close this issue, but we need a clear statement to that effect.
            Hide
            pgee Perry Gee added a comment -

            i agree. So I will just take it out of the review loop and defer it.

            Show
            pgee Perry Gee added a comment - i agree. So I will just take it out of the review loop and defer it.
            Hide
            pgee Perry Gee added a comment -

            Actually, I guess there is no way for me to mark it as deferred, so will just put it is a working state again and you can move it to another sprint.

            Show
            pgee Perry Gee added a comment - Actually, I guess there is no way for me to mark it as deferred, so will just put it is a working state again and you can move it to another sprint.
            Hide
            swinbank John Swinbank added a comment -

            Since this ticket covers multiple issues, I think it makes sense to close this one down now and file a specific ticket for the aperture corrections to _photometryKron. So I've done that; new ticket is DM-2429.

            Show
            swinbank John Swinbank added a comment - Since this ticket covers multiple issues, I think it makes sense to close this one down now and file a specific ticket for the aperture corrections to _photometryKron . So I've done that; new ticket is DM-2429 .

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                pgee Perry Gee
                Reviewers:
                John Swinbank
                Watchers:
                Jim Bosch, John Swinbank, Perry Gee, Robyn Allsman [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel