Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_photometryKron
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-S15-1
-
Team:Data Release Production
Description
These are to note leftovers from DM-982. They could be done in a single issue.
1. I commented code out referring to correctfluxes, but it will need to be restored once it is available in the new framework.
2. Jim asked me to replace the computeSincFlux which is currently in PsfImage.cc in meas_algorithms with a similar call in meas_base/ApertureFlux.cc. I did not do this because it became rather complicated, and can just as easily be done when the meas_algorithms routine is moved or removed. Basically, the templating in ApertureFlux is on Pixel type, whereas in meas_algorithms it is on ImageT (where ImageT is not necessarily a single class hierarchy – e.g., Image and MaskedImage). So I left this for now.
Attachments
Issue Links
Activity
Team | Princeton [ 10301 ] |
Epic Link |
|
Sprint | Science Pipelines DM-S15-1 [ 140 ] |
Rank | Ranked higher |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Reviewers | John Swinbank [ swinbank ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | To Do [ 10001 ] |
Resolution | Done [ 10000 ] | |
Status | To Do [ 10001 ] | Done [ 10002 ] |
Component/s | meas_extensions_photometryKron [ 12318 ] | |
Component/s | meas_extensions_kron [ 10737 ] |
Do we have an issue for making correctfluxes code available in the new framework? Please make sure it's linked to this one, so this doesn't get forgotten.
I assume the removal of computeSincFlux from meas_algorithms is covered by
DM-420, so I've linked that issue. (I'm not sure I understand why deferring this work until that issue is addressed is desirable, but it doesn't seem to be a big deal).Jim Bosch Shall we add this to DM-1768 for S15?