Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19541

Test latest version of pointing component with SAL 3.9

    XMLWordPrintable

Details

    Description

      Vendor released latest version of pointing component. Initial tests showed some issues with the component that need to be addressed and may have shown an issue with SAL 3.9/SalObj 3.11.0. This task will be used to continue testing the pointing component and SAL.

      Following Dave's suggestion I will spin up a EFD for the components to monitor the SAL traffic. I will also use this task to document a procedure on running integration and test on stage machines.

      Documentation will go here:

      https://confluence.lsstcorp.org/display/LTS/Integration+Testing+and+Deployment+Development+Procedure

      Attachments

        Activity

          I think I'm done doing a first round of testing of the pointing component with the ATMCS. Overall this task spun up a lot of different tickets to fix multiple things, uncovered a bug with SAL + SALOBJ and advanced on a good number of procedures on running integration tests.

          Here is a list of artifacts generated by this task:

          Ticket for pointing component vendors to fix behavior when reaching a limit: TPC-167
          Ticket for fixing ack accumulation issue in salobj: DM-19581
          Ticket for fixing ack indexing in SAL: DM-19579 (opened by rowen following discussion on handling acks)
          New docker container with pointing component and sal 3.9 (https://cloud.docker.com/u/tiagorib/repository/docker/tiagorib/ptkernel): docker pull tiagorib/ptkernel:RCv0.3_sal3.9
          Docker compose file with EFD + efd-writters + atmcs + atptg + script: https://github.com/lsst-ts/ts_Dockerfiles/pull/13

          Added notebooks to run track tests and script to duplicate the ack accumulation issue to ts_notebook. I accidentally added those into a different branch and merged it with an old PR (https://github.com/lsst-ts/ts_notebooks/pull/2).

          PR on pointing component to fix rotator limits: https://github.com/lsst-ts/ts_pointing_common/pull/1 (will be reviewed by vendors).

          tribeiro Tiago Ribeiro added a comment - I think I'm done doing a first round of testing of the pointing component with the ATMCS. Overall this task spun up a lot of different tickets to fix multiple things, uncovered a bug with SAL + SALOBJ and advanced on a good number of procedures on running integration tests. Here is a list of artifacts generated by this task: Ticket for pointing component vendors to fix behavior when reaching a limit: TPC-167 Ticket for fixing ack accumulation issue in salobj: DM-19581 Ticket for fixing ack indexing in SAL: DM-19579 (opened by rowen following discussion on handling acks) New docker container with pointing component and sal 3.9 ( https://cloud.docker.com/u/tiagorib/repository/docker/tiagorib/ptkernel): docker pull tiagorib/ptkernel:RCv0.3_sal3.9 Docker compose file with EFD + efd-writters + atmcs + atptg + script: https://github.com/lsst-ts/ts_Dockerfiles/pull/13 Added notebooks to run track tests and script to duplicate the ack accumulation issue to ts_notebook. I accidentally added those into a different branch and merged it with an old PR ( https://github.com/lsst-ts/ts_notebooks/pull/2 ). PR on pointing component to fix rotator limits: https://github.com/lsst-ts/ts_pointing_common/pull/1 (will be reviewed by vendors).

          After some consideration, I think it would be good to formalize a bit more the actual test that was conducted in this ticket. I put it back in progress so I can work on it. I will add an integration script in ts_standardscript. Hopefully rbovill can help me formalize a bit better the test report.

          tribeiro Tiago Ribeiro added a comment - After some consideration, I think it would be good to formalize a bit more the actual test that was conducted in this ticket. I put it back in progress so I can work on it. I will add an integration script in ts_standardscript. Hopefully rbovill can help me formalize a bit better the test report.

          Ok, now it is ready for review.

          Additional PR to ts_standardscript: https://github.com/lsst-ts/ts_standardscripts/pull/11

          rowen may want to take a look at that one in particular.

          List of previous artifacts:

          Ticket for pointing component vendors to fix behavior when reaching a limit: TPC-167
          Ticket for fixing ack accumulation issue in salobj: DM-19581
          Ticket for fixing ack indexing in SAL: DM-19579 (opened by Russell Owen following discussion on handling acks)
          New docker container with pointing component and sal 3.9 (https://cloud.docker.com/u/tiagorib/repository/docker/tiagorib/ptkernel): docker pull tiagorib/ptkernel:RCv0.3_sal3.9
          Docker compose file with EFD + efd-writters + atmcs + atptg + script: https://github.com/lsst-ts/ts_Dockerfiles/pull/13
          Added notebooks to run track tests and script to duplicate the ack accumulation issue to ts_notebook. I accidentally added those into a different branch and merged it with an old PR (https://github.com/lsst-ts/ts_notebooks/pull/2).
          PR on pointing component to fix rotator limits: https://github.com/lsst-ts/ts_pointing_common/pull/1 (will be reviewed by vendors).

          tribeiro Tiago Ribeiro added a comment - Ok, now it is ready for review. Additional PR to ts_standardscript: https://github.com/lsst-ts/ts_standardscripts/pull/11 rowen may want to take a look at that one in particular. List of previous artifacts: Ticket for pointing component vendors to fix behavior when reaching a limit: TPC-167 Ticket for fixing ack accumulation issue in salobj: DM-19581 Ticket for fixing ack indexing in SAL: DM-19579 (opened by Russell Owen following discussion on handling acks) New docker container with pointing component and sal 3.9 ( https://cloud.docker.com/u/tiagorib/repository/docker/tiagorib/ptkernel): docker pull tiagorib/ptkernel:RCv0.3_sal3.9 Docker compose file with EFD + efd-writters + atmcs + atptg + script: https://github.com/lsst-ts/ts_Dockerfiles/pull/13 Added notebooks to run track tests and script to duplicate the ack accumulation issue to ts_notebook. I accidentally added those into a different branch and merged it with an old PR ( https://github.com/lsst-ts/ts_notebooks/pull/2 ). PR on pointing component to fix rotator limits: https://github.com/lsst-ts/ts_pointing_common/pull/1 (will be reviewed by vendors).
          ecoughlin Eric Coughlin added a comment - - edited

          I have run some of the changes and looked at the docker files. It all looks good to me.

          ecoughlin Eric Coughlin added a comment - - edited I have run some of the changes and looked at the docker files. It all looks good to me.

          People

            tribeiro Tiago Ribeiro
            tribeiro Tiago Ribeiro
            Eric Coughlin
            Andy Clements, Dave Mills, Eric Coughlin, James Buffill [X] (Inactive), Patrick Ingraham (Inactive), Rob Bovill, Russell Owen, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.