Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19569

Update ts_ScriptQueue to use the dds version of ts_salobj

    XMLWordPrintable

    Details

      Description

      Update ts_ScriptQueue to use the version of ts_salobj based on dds. This is primarily intended to exercise the new version of ts_salobj.

        Attachments

          Issue Links

          contains

          Improvement - An improvement or enhancement to an existing feature or task. DM-19644 Use a single remote to interact with all scripts

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19385 Rewrite ts_salobj to use OpenSplice dds

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-16920 [ 238253 ]
            rowen Russell Owen made changes -
            Link This issue is triggered by DM-19385 [ DM-19385 ]
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Sprint TSSW Sprint - Apr 29 - May 11 [ 881 ] TSSW Sprint - May 13 - May 25 [ 882 ]
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Additional changes:

            • Use a single salobj.Remote in the queue model to communicate with all scripts. This is faster and more efficient than building a separate remote to talk to each script. It does require a bit of care to set the ScriptID field (which is the name of the SAL index field for Script topics) before sending a command to a script.
            • Add a log attribute to QueueModel and ScriptInfo.

            Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/27

            Show
            rowen Russell Owen added a comment - - edited Additional changes: Use a single salobj.Remote in the queue model to communicate with all scripts. This is faster and more efficient than building a separate remote to talk to each script. It does require a bit of care to set the ScriptID field (which is the name of the SAL index field for Script topics) before sending a command to a script. Add a log attribute to QueueModel and ScriptInfo. Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/27
            rowen Russell Owen made changes -
            Reviewers Eric Coughlin [ ecoughlin ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Link This issue contains DM-19644 [ DM-19644 ]
            Hide
            Permalink
            ecoughlin Eric Coughlin added a comment -

            Approved on github.

            Show
            ecoughlin Eric Coughlin added a comment - Approved on github.
            ecoughlin Eric Coughlin made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Merged to develop and tagged as v2.0b1; this tag also includes the conversion to use dds salobj. I plan to hold off merging to master until dds salobj can communication with SAL 3.9.

            Show
            rowen Russell Owen added a comment - Merged to develop and tagged as v2.0b1; this tag also includes the conversion to use dds salobj. I plan to hold off merging to master until dds salobj can communication with SAL 3.9.
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.