Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19570

Fix raw_sub testing in obs_base

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, obs_lsst, obs_test
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Arch 2019-04-29
    • Team:
      Architecture

      Description

      DM-8097 uncovered a problem with raw_sub in the butler that resulted in some fixes in DM-13696 but left the underlying problem remaining because raw in obs_base was still defined as a DecoratedImageU.

      In this ticket I will:

      • Change raw to ExposureU (which is more inline with other obs packages).
      • Re-enable the test for raw_sub (and fix it)
      • Update obs_test test to expect ExposureU
      • Fix obs_lsst raw_sub now that the test it uses from obs_base will be enabled.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I had a quick look at this. I fixed obs_base and obs_test to use ExposureU and raw_sub did then work. Unfortunately changing this broke obs_lsstSim because they expect a header correction applied in the mapper to be available to the WCS constructor and that seems to break. obs_lsst is also much harder to fix for raw_sub and I ended up disabling the test. I think I'm going to pull this from the sprint and unassign myself since it seems it will take much more effort to sort things out.

            Show
            tjenness Tim Jenness added a comment - I had a quick look at this. I fixed obs_base and obs_test to use ExposureU and raw_sub did then work. Unfortunately changing this broke obs_lsstSim because they expect a header correction applied in the mapper to be available to the WCS constructor and that seems to break. obs_lsst is also much harder to fix for raw_sub and I ended up disabling the test. I think I'm going to pull this from the sprint and unassign myself since it seems it will take much more effort to sort things out.
            Hide
            tjenness Tim Jenness added a comment -

            I'm going to close this as Won't Fix given that it's entirely a gen2 problem and it seems to be harder to fix than is sensible.

            Show
            tjenness Tim Jenness added a comment - I'm going to close this as Won't Fix given that it's entirely a gen2 problem and it seems to be harder to fix than is sensible.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Kian-Tat Lim, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.