Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19622

Make PosixDatastore's internal table lowercase

    Details

      Description

      DM-17633 failed to lowercase PosixDatastoreRecords, as it's defined in a totally different way from the rest of the schema.  Fix that.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Tim Jenness, since you've already taken a look...

          Michelle Gower, Hsin-Fang Chiang, if either of you can confirm that the table name length issue Tim already raised is not a concern, I'll feel better about merging this.  If you can't, I may merge it anyway to get it in the weekly (if Tim approves).

          Show
          jbosch Jim Bosch added a comment - Tim Jenness , since you've already taken a look... Michelle Gower , Hsin-Fang Chiang , if either of you can confirm that the table name length issue Tim already raised is not a concern, I'll feel better about merging this.  If you can't, I may merge it anyway to get it in the weekly (if Tim approves).
          Hide
          tjenness Tim Jenness added a comment -

          Looks fine. I'm okay with merging as is since it is an improvement even if we have a problem concerning table lengths for Oracle. It's at least easy for someone doing a test to change the length of the string in their own butler configuration without affecting anyone else.

          Show
          tjenness Tim Jenness added a comment - Looks fine. I'm okay with merging as is since it is an improvement even if we have a problem concerning table lengths for Oracle. It's at least easy for someone doing a test to change the length of the string in their own butler configuration without affecting anyone else.
          Hide
          mgower Michelle Gower added a comment -

          While other folks have had problems with the table name length, I have never run into this problem on my workstation.    Here's the table in my oracle schema:

          SQL> select table_name from all_tables where owner='GEN3_MGOWER_1' and table_name like 'POSIX%';
          TABLE_NAME
          --------------------------------------------------------------------------------
          POSIX_DATASTORE_RECORDS
          

          When I have a chance, it's on my todo list to figure out why those running on lsst-dev do get that error message.   And like Tim mentioned, there's a way to work around it for a little while.

          I didn't have time to run a full pipeline test using this branch.   But I did successfully run from makeButlerRepo.py, gen3.py, ..., through a couple ISR tasks in the single node activator and a quick check of filesystem and DB showed the output files.   I am okay with merging this branch.

           

          Show
          mgower Michelle Gower added a comment - While other folks have had problems with the table name length, I have never run into this problem on my workstation.    Here's the table in my oracle schema: SQL> select table_name from all_tables where owner= 'GEN3_MGOWER_1' and table_name like 'POSIX%' ; TABLE_NAME -------------------------------------------------------------------------------- POSIX_DATASTORE_RECORDS When I have a chance, it's on my todo list to figure out why those running on lsst-dev do get that error message.   And like Tim mentioned, there's a way to work around it for a little while. I didn't have time to run a full pipeline test using this branch.   But I did successfully run from makeButlerRepo.py, gen3.py, ..., through a couple ISR tasks in the single node activator and a quick check of filesystem and DB showed the output files.   I am okay with merging this branch.  

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Tim Jenness
              Watchers:
              Jim Bosch, Michelle Gower, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel