Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19677

Disable writing postISRCCDs in ProcessCcdTask

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      Per discussion on Slack, ProcessCcdTask should set doWrite=False on it's IsrTask subtask.

      And please also make sure there aren't unnecessary overrides in obs packages.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment - - edited

            On this ticket, I have:

            Several camera packages (including the above obs_decam) have a config/isr.py which sets doWrite=False without specifically relating that to a ProcessCcdTask config (i.e., those files might be used standalone and/or included in another config file). It might be appropriate to reorganize these configurations so that that doWrite setting lives in a processCcd.py config file, but I decided that sort of cleaning up was out of scope for this ticket.

            Show
            swinbank John Swinbank added a comment - - edited On this ticket, I have: Set IsrTask.ConfigClass.doWrite=False when run as part of ProcessCcdTask ; Removed the re-assertion of the above in obs_subaru ; Removed a re-assertion IsrTask.ConfigClass.doWrite=True in obs_decam . Several camera packages (including the above obs_decam) have a config/isr.py which sets doWrite=False without specifically relating that to a ProcessCcdTask config (i.e., those files might be used standalone and/or included in another config file). It might be appropriate to reorganize these configurations so that that doWrite setting lives in a processCcd.py config file, but I decided that sort of cleaning up was out of scope for this ticket.
            Hide
            swinbank John Swinbank added a comment -

            Jenkins: https://ci.lsst.codes/job/stack-os-matrix/29807/ (still running at time of writing).

            Show
            swinbank John Swinbank added a comment - Jenkins: https://ci.lsst.codes/job/stack-os-matrix/29807/ (still running at time of writing).
            Hide
            swinbank John Swinbank added a comment -

            Hey Paul, does this look ok to you?

            Show
            swinbank John Swinbank added a comment - Hey Paul, does this look ok to you?
            Hide
            price Paul Price added a comment -

            I'm going to duck the review in favour of Christopher Waters, as he understands the issues better than I.

            Show
            price Paul Price added a comment - I'm going to duck the review in favour of Christopher Waters , as he understands the issues better than I.
            Hide
            czw Christopher Waters added a comment -

            This looks like it'll be fine in Gen3, and keep the Gen2 disk space down.

            Show
            czw Christopher Waters added a comment - This looks like it'll be fine in Gen3, and keep the Gen2 disk space down.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for the review; merged.

            Show
            swinbank John Swinbank added a comment - Thanks for the review; merged.

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Christopher Waters
                Watchers:
                Christopher Waters, Colin Slater, Heather Kelly, John Swinbank, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel