Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19695

ci_hsc fails tests on NFS

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Arch 2019-05-06
    • Team:
      Architecture

      Description

      Since moving Jenkins to NCSA one of the ci_hsc tests fails because the clean up code attempts to clear out a directory but some files are still open and owned by the process. On local filesystems this works fine but on NFS deleted but open files become temporary files and rmtree gets upset when they hang around. tempfile.TemporaryDirectory does not know about those open files and does not run rmtree with the flag to ignore errors.

      The fix is either to move the clean up code to tearDown or else see if a del works.

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          Kian-Tat Lim deleting the butler objects inside the context manager is a simple fix that allows the tests to pass. Please let me know whether this quick patch is enough or if you would like me to reorganize things a bit to use explicit mkdtemp and rmtree calls in the test.

          Show
          tjenness Tim Jenness added a comment - Kian-Tat Lim deleting the butler objects inside the context manager is a simple fix that allows the tests to pass. Please let me know whether this quick patch is enough or if you would like me to reorganize things a bit to use explicit mkdtemp and rmtree calls in the test.
          Hide
          ktl Kian-Tat Lim added a comment -

          LGTM.

          Show
          ktl Kian-Tat Lim added a comment - LGTM.

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Jim Bosch, Joshua Hoblitt, Kian-Tat Lim, Simon Krughoff, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel