Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19707

ip_isr tests do not all test functionality

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      Some unit tests for ip_isr only test that the code completes, not that the output/result of the test is correct.  This ticket notes these tests, and should be updated if/when clear results are generated by the function tested.

        Attachments

          Issue Links

          FF-depends on

          Improvement - An improvement or enhancement to an existing feature or task. DM-15683 Add tests for ip_isr/isrTask

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            czw Christopher Waters created issue -
            czw Christopher Waters made changes -
            Field Original Value New Value
            Link This issue FF-depends on DM-15683 [ DM-15683 ]
            Hide
            Permalink
            czw Christopher Waters added a comment -

            List of tests that test poorly:

            test_isrMisc.py: test_vignette_noWrite, test_masking, test_linearize,

            test_isrFunctions.py: test_attachTransmissionCurve, test_attachTransmissionCurve_None

            Show
            czw Christopher Waters added a comment - List of tests that test poorly: test_isrMisc.py: test_vignette_noWrite, test_masking, test_linearize, test_isrFunctions.py: test_attachTransmissionCurve, test_attachTransmissionCurve_None
            tjenness Tim Jenness made changes -
            Remote Link This issue links to "Page (Confluence)" [ 35572 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Christopher Waters is this still relevant or has it been subsumed into other tickets?

            Show
            tjenness Tim Jenness added a comment - Christopher Waters is this still relevant or has it been subsumed into other tickets?
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I think something needs to be done on this before closing it, as there are references to this ticket in the code.  I'll add this to one of the epics I watch so it doesn't get lost again, and will think about if those tests still need improvement, or if those references just need to be removed.

            Show
            czw Christopher Waters added a comment - I think something needs to be done on this before closing it, as there are references to this ticket in the code.  I'll add this to one of the epics I watch so it doesn't get lost again, and will think about if those tests still need improvement, or if those references just need to be removed.
            czw Christopher Waters made changes -
            Epic Link DM-32170 [ 779886 ]
            czw Christopher Waters made changes -
            Epic Link DM-32170 [ 779886 ] DM-32177 [ 779901 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-32177 [ 779901 ] DM-32184 [ 779908 ]
            yusra Yusra AlSayyad made changes -
            Epic Link DM-32184 [ 779908 ] DM-32191 [ 779935 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              czw Christopher Waters
              Watchers:
              Christopher Waters, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.