Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19709

Write a first version of a defect finding task

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      Lab testing of ComCam motivates a first pass at developing some long-overdue calibration product production code, as this will allow the ComCam commissioning team to efficiently assess performance as a function of temperature (among other things) as they acquire lab data over the (past and) coming weeks.

      The ticket will cover making a first pass at writing a defect finding task to support this work.

      Defect Task:

      • Find bright & dark pixels from darks and flats
      • Persist as ASCII text files so they can be treated as defects in the normal (old & bad) way
      • Summary stats for each amp (and for each sensor)

      Task should be able to run on either single master calibs (both darks and flats), or a list or raw input files, processing each as it should, and applying pixel-wise cuts to reduce the false-positive rate, i.e. making use of being fed multiple raw inputs.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Regarding defects, use measAlg.Defects.writeText() to generate your defect text files.

            Show
            tjenness Tim Jenness added a comment - Regarding defects, use measAlg.Defects.writeText() to generate your defect text files.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Task is written, code is rebased. Marking ticket as Done for now. Code will be reviewed separately as DM-20068.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Task is written, code is rebased. Marking ticket as Done for now. Code will be reviewed separately as DM-20068 .
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            As above.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - As above.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment - - edited

            Changes from the review of the defects part of DM-20069 are on this branch, and await a (hopefully much briefer) re-review here (as discussed OOB).

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - - edited Changes from the review of the defects part of DM-20069 are on this branch, and await a (hopefully much briefer) re-review here (as discussed OOB).
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Merged by John Swinbank

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Merged by John Swinbank

              People

              • Assignee:
                mfisherlevine Merlin Fisher-Levine
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Reviewers:
                John Parejko
                Watchers:
                Andrés Alejandro Plazas Malagón, Brian Stalder, John Parejko, John Swinbank, Merlin Fisher-Levine, Pierre Astier, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel