Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19817

Make a package like ci_hsc for generation 3 bulter

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      20
    • Sprint:
      DRP S19-6a, DRP S19-6b, DRP F19-1
    • Team:
      Data Release Production

      Description

      This package should be a re-runable repository that does the same processing as ci_hsc, but using gen3 middleware. This package will not duplicate the data stored in ci_hsc but link against it, and thus will depend on ci_hsc

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            I got busy with a few other things, so I apologize about taking so long to get this out to review to you both.
            Meredith can you look at the testdata_ci_hsc and ci_hsc_gen2 repos? It is mostly just splitting apart ci_hsc into those two.
            Hsin-Fang, can you look at the ci_hsc_gen3 repo? You will need the testdata_ci_hsc cloned and setup if you want to run it.

            Thank you both.

            Show
            nlust Nate Lust added a comment - I got busy with a few other things, so I apologize about taking so long to get this out to review to you both. Meredith can you look at the testdata_ci_hsc and ci_hsc_gen2 repos? It is mostly just splitting apart ci_hsc into those two. Hsin-Fang, can you look at the ci_hsc_gen3 repo? You will need the testdata_ci_hsc cloned and setup if you want to run it. Thank you both.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Done with my part of the review, so I'm removing my name from the reviewers. Comments on the PR.

             
            I was able to get ci_hsc_gen3 running.  Because it wasn't my first attempt scons-ing, I needed to manually delete the gen3.sqlite3 file, the "shared" folder, and the symlinks. Do we expect users to clean up after failed attempts, or could it be done more automatically?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Done with my part of the review, so I'm removing my name from the reviewers. Comments on the PR.   I was able to get ci_hsc_gen3 running.  Because it wasn't my first attempt scons-ing, I needed to manually delete the gen3.sqlite3 file, the "shared" folder, and the symlinks. Do we expect users to clean up after failed attempts, or could it be done more automatically?
            Hide
            nlust Nate Lust added a comment -

            If you run scons --clean it resets everything for you.

            Show
            nlust Nate Lust added a comment - If you run scons --clean it resets everything for you.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            That did exactly what I wanted – thanks!

            Show
            hchiang2 Hsin-Fang Chiang added a comment - That did exactly what I wanted – thanks!
            Hide
            mrawls Meredith Rawls added a comment -

            I did my initial review, and left comments on GitHub. I think it's great to have this broken out as a code repo and a data repo, but that we should take the opportunity to add at least placeholder documentation to each new repo, and whenever feasible model these "new" packages after the example templates in https://github.com/lsst/templates/tree/master/project_templates/stack_package.

            Show
            mrawls Meredith Rawls added a comment - I did my initial review, and left comments on GitHub. I think it's great to have this broken out as a code repo and a data repo, but that we should take the opportunity to add at least placeholder documentation to each new repo, and whenever feasible model these "new" packages after the example templates in https://github.com/lsst/templates/tree/master/project_templates/stack_package .
            Hide
            nlust Nate Lust added a comment -

            Bumping the story points for this ticket as it ended up encompassing changes to split ci_hsc up into two additional packages.

            Show
            nlust Nate Lust added a comment - Bumping the story points for this ticket as it ended up encompassing changes to split ci_hsc up into two additional packages.

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                nlust Nate Lust
                Reviewers:
                Meredith Rawls
                Watchers:
                Hsin-Fang Chiang, Meredith Rawls, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel