Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:20
-
Epic Link:
-
Sprint:DRP S19-6a, DRP S19-6b, DRP F19-1
-
Team:Data Release Production
Description
This package should be a re-runable repository that does the same processing as ci_hsc, but using gen3 middleware. This package will not duplicate the data stored in ci_hsc but link against it, and thus will depend on ci_hsc
Attachments
Issue Links
- is triggered by
-
- Implemented
Activity
Done with my part of the review, so I'm removing my name from the reviewers. Comments on the PR.
I was able to get ci_hsc_gen3 running. Because it wasn't my first attempt scons-ing, I needed to manually delete the gen3.sqlite3 file, the "shared" folder, and the symlinks. Do we expect users to clean up after failed attempts, or could it be done more automatically?
Hsin-Fang Chiang
added a comment - Done with my part of the review, so I'm removing my name from the reviewers. Comments on the PR.
I was able to get ci_hsc_gen3 running. Because it wasn't my first attempt scons-ing, I needed to manually delete the gen3.sqlite3 file, the "shared" folder, and the symlinks. Do we expect users to clean up after failed attempts, or could it be done more automatically? If you run scons --clean it resets everything for you.
That did exactly what I wanted – thanks!
Hsin-Fang Chiang
added a comment - That did exactly what I wanted – thanks! I did my initial review, and left comments on GitHub. I think it's great to have this broken out as a code repo and a data repo, but that we should take the opportunity to add at least placeholder documentation to each new repo, and whenever feasible model these "new" packages after the example templates in https://github.com/lsst/templates/tree/master/project_templates/stack_package.
Bumping the story points for this ticket as it ended up encompassing changes to split ci_hsc up into two additional packages.
I got busy with a few other things, so I apologize about taking so long to get this out to review to you both.
Meredith can you look at the testdata_ci_hsc and ci_hsc_gen2 repos? It is mostly just splitting apart ci_hsc into those two.
Hsin-Fang, can you look at the ci_hsc_gen3 repo? You will need the testdata_ci_hsc cloned and setup if you want to run it.
Thank you both.