Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19818

Fix Gen3 Butler pickling broken on DM-19638

    Details

      Description

      DM-19638 added a new butler constructor argument and broke pickling.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment - - edited

            Nate Lust, sorry this slowed you down earlier today.  Good news is that adding a test was trivial, so this is ready for review.

            PR is here: https://github.com/lsst/daf_butler/pull/162

            Show
            jbosch Jim Bosch added a comment - - edited Nate Lust , sorry this slowed you down earlier today.  Good news is that adding a test was trivial, so this is ready for review. PR is here: https://github.com/lsst/daf_butler/pull/162
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Don't know how exactly, but this ticket solves a multiprocessing error I was seeing with DM-19638 and w_2019_20. The error message was "TypeError: Butler is read-only" which was just misleading.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Don't know how exactly, but this ticket solves a multiprocessing error I was seeing with DM-19638 and w_2019_20. The error message was "TypeError: Butler is read-only" which was just misleading.
            Hide
            jbosch Jim Bosch added a comment -

            That was the symptom Nate Lust saw, too - the problem was that after unpickling the original "run" argument (which is used to initialize a read-write butler) was being passed as the "collection" argument (which makes a read-only butler).

             

            Show
            jbosch Jim Bosch added a comment - That was the symptom Nate Lust saw, too - the problem was that after unpickling the original "run" argument (which is used to initialize a read-write butler) was being passed as the "collection" argument (which makes a read-only butler).  

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Nate Lust
                Watchers:
                Hsin-Fang Chiang, Jim Bosch, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel