Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19852

skyCorrectionTask should be moved to pipe_tasks for Gen3

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Team:
      Architecture

      Description

      The rework of SkyCorrectionTask for Gen3 duplicates code and methods, which is needed to convert the ctrl_pool processing into a pipetask.  The eventual goal is to migrate the pipetask version of this into pipe_tasks.

        Attachments

          Issue Links

          FF-depends on

          Improvement - An improvement or enhancement to an existing feature or task. DM-18531 convert skyCorrection to gen3 pipelineTask

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-29835 pipe_drivers background code needs migration

          • Done

            Activity

            Ascending order - Click to sort in descending order
            4 older comments
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            I was under the impression that pipe_drivers is covered under the general gen2 removal RFC pending this ticket, but we could make it another very simple RFC if you wish.

            Show
            erykoff Eli Rykoff added a comment - I was under the impression that pipe_drivers is covered under the general gen2 removal RFC pending this ticket, but we could make it another very simple RFC if you wish.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Hmm. You make a good point. Once I stripped all the code out of pipe base the entire thing became useless for Gen 2. I will remove the entries.

            Show
            tjenness Tim Jenness added a comment - Hmm. You make a good point. Once I stripped all the code out of pipe base the entire thing became useless for Gen 2. I will remove the entries.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            However... in the light of the morning, I wonder if this is possible without leaving in a deprecated stub for the removed tasks? Up until now it has been perfectly legal to import from pipe_drivers to get the gen3 SkyCorrectionTask so there are going to be workflows out there that expect that to be available.

            Show
            erykoff Eli Rykoff added a comment - However... in the light of the morning, I wonder if this is possible without leaving in a deprecated stub for the removed tasks? Up until now it has been perfectly legal to import from pipe_drivers to get the gen3 SkyCorrectionTask so there are going to be workflows out there that expect that to be available.
            Hide
            Permalink
            tjenness Tim Jenness added a comment - - edited

            Kian-Tat Lim what do you think we should do? I'm fine leaving pipe_drivers around and I'm fine making it disappear.

            I can add a deprecation message around background and SkyCorrectionTask and leave pipe_Drivers in for 6 months. It's not like it takes a long time to build pipe_drivers.

            Show
            tjenness Tim Jenness added a comment - - edited Kian-Tat Lim what do you think we should do? I'm fine leaving pipe_drivers around and I'm fine making it disappear. I can add a deprecation message around background and SkyCorrectionTask and leave pipe_Drivers in for 6 months. It's not like it takes a long time to build pipe_drivers.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            I agree with Eli that a deprecation/transition period is in order. It was not only perfectly legal to import this code, but there was no alternative for people using this code. We need to protect them for at least a little while.

            Show
            ktl Kian-Tat Lim added a comment - I agree with Eli that a deprecation/transition period is in order. It was not only perfectly legal to import this code, but there was no alternative for people using this code. We need to protect them for at least a little while.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              czw Christopher Waters
              Reviewers:
              Eli Rykoff
              Watchers:
              Christopher Waters, Eli Rykoff, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.